Revert 9ce0100 due to breaking change with pantsd #8476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…antsbuild#8467)" This reverts commit 9ce0100.
|
Note: it seems to only repro when running with pantsd. (At least that's my interpretation of master failing only on the cron job). I can reproduce it locally by running any pants command (tried |
Eric-Arellano
approved these changes
Oct 15, 2019
pierrechevalier83
changed the title
ity
approved these changes
Oct 15, 2019
@Eric-Arellano - See #8476 (review) 😉 |
Eric-Arellano
pushed a commit
to Eric-Arellano/pants
that referenced
this pull request
Nov 5, 2019
…hints (pantsbuild#8467)" (pantsbuild#8476)" This reverts commit ba19f53.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Master is broken (see https://travis-ci.org/pantsbuild/pants/jobs/598005991)
Solution
Revert offending commit (From local bisect)
Result
Revert "Modify
engine.objects.Collectionto work with type hints (#8467)"This reverts commit 9ce0100.