Disable capturing core dumps in travis #9769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…are likely running us out of disk space on shards that test by sending `SIGABRT`. # Delete this line to force CI to run Clippy and the Rust tests. [ci skip-rust-tests] # Delete this line to force CI to run the JVM tests. [ci skip-jvm-tests]
Eric-Arellano
approved these changes
May 14, 2020
stuhood
pushed a commit
that referenced
this pull request
May 14, 2020
### Problem A while back we started capturing core dumps "globally" in travis. But in practice we have never consumed them, and I'm fairly certain that they are causing the OSX shards that test sending `SIGABRT` (which, if core dumps are enabled, will trigger a core dump) to `pantsd` to: 1. be racey, because while the core is dumping, the process is non-responsive and can't be killed, leading to errors like: ```FAILURE: failure while terminating pantsd: failed to kill pid 28775 with signals (<Signals.SIGTERM: 15>, <Signals.SIGKILL: 9>)``` 2. run out of disk space: we've seen mysterious "out of disk" errors on the OSX shards... and core dumps are large. ### Solution Disable core dumps everywhere. If we end up needing them in the future, we can enable them on a case-by-case basis. ### Result Fixes #8127. [ci skip-rust-tests] [ci skip-jvm-tests]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
A while back we started capturing core dumps "globally" in travis. But in practice we have never consumed them, and I'm fairly certain that they are causing the OSX shards that test sending
SIGABRT(which, if core dumps are enabled, will trigger a core dump) topantsdto:FAILURE: failure while terminating pantsd: failed to kill pid 28775 with signals (<Signals.SIGTERM: 15>, <Signals.SIGKILL: 9>)Solution
Disable core dumps everywhere. If we end up needing them in the future, we can enable them on a case-by-case basis.
Result
Fixes #8127.
[ci skip-rust-tests]
[ci skip-jvm-tests]