Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable flake8 checks: F723 and F821 #9776

Merged
merged 1 commit into from
May 23, 2020
Merged

Conversation

asherf
Copy link
Member

@asherf asherf commented May 15, 2020

F723 - Unrecognized syntax in type comment
F821 - undefined name

@Eric-Arellano
Copy link
Contributor

We first need to upgrade to the newest Flake8 release to be able to do this.

@asherf asherf force-pushed the repr branch 2 times, most recently from 97681e5 to 30d7a0a Compare May 22, 2020 03:15
F723 - Unrecognized syntax in type comment
F821 - undefined name
@asherf
Copy link
Member Author

asherf commented May 23, 2020

since #9859 was merged this should be g2g.

@Eric-Arellano Eric-Arellano merged commit ac3e816 into pantsbuild:master May 23, 2020
@Eric-Arellano
Copy link
Contributor

Thank you Asher! Very excited to see these checks be restored.

@asherf asherf deleted the repr branch May 23, 2020 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants