Fix fmt and lint re-runs under pantsd #9869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry: the first commit definitely should have been two. |
Eric-Arellano
approved these changes
May 26, 2020
…fix `__eq__` for that type by extending dataclass to include all members in equality. [ci skip-rust-tests] [ci skip-jvm-tests]
# Delete this line to force CI to run Clippy and the Rust tests. [ci skip-rust-tests] # Delete this line to force CI to run the JVM tests. [ci skip-jvm-tests]
# Delete this line to force CI to run Clippy and the Rust tests. [ci skip-rust-tests] # Delete this line to force CI to run the JVM tests. [ci skip-jvm-tests]
stuhood
force-pushed
the
stuhood/fmt-field-sets-equals
branch
from
9986123
to
4aeefb5
Compare
Eric-Arellano
approved these changes
May 26, 2020
| requests.append(all_source_files_request) | ||
| requirements_pex, specified_source_files, *rest = cast( | ||
| Union[Tuple[Pex, SourceFiles], Tuple[Pex, SourceFiles, SourceFiles]], | ||
| await MultiGet(requests), | ||
| ) | ||
|
|
||
| all_source_files_snapshot = ( | ||
| request.field_sets.prior_formatter_result | ||
| if request.field_sets.prior_formatter_result | ||
| request.request.prior_formatter_result |
There was a problem hiding this comment.
Oh, hm. This is weird naming. It'd be great to rename the parameter to setup_request and rename the property SetupRequest.request to SetupRequest.docformatter_request. Ditto on Black and Isort.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
FmtFieldSetsandLinterFieldSetstypes extendedCollection(which implements usefuleq/hash), but then added an additional optional field,prior_formatter_result. But that additional field was not included in theeq/hashfor the type, and this meant that instances of these objects would be equal regardless of the previous result. This resulted inpantsdmemoizing the wrong input for runs: in short, havoc.Solution
Extract
StyleRequestto replaceFmtFieldSetsandLinterFieldSets, and fix__eq__for that type by extending dataclass. Additionally, align allFmtandLintFieldSetstypes around the nameRequest.Result
Operation of
fmtandlintis correct underpantsd.[ci skip-rust-tests]
[ci skip-jvm-tests]