Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix fmt and lint re-runs under pantsd #9869

Merged
merged 3 commits into from May 26, 2020
Merged

Fix fmt and lint re-runs under pantsd #9869

merged 3 commits into from May 26, 2020

Commits on May 26, 2020

  1. Extract StyleRequest from FmtFieldSets and LinterFieldSets and … 

    …fix `__eq__` for that type by extending dataclass to include all members in equality.

[ci skip-rust-tests]
[ci skip-jvm-tests]
    @stuhood
    stuhood committed May 26, 2020
    Configuration menu
    Copy the full SHA
    dc0ad10 View commit details
    Browse the repository at this point in the history

  2. Add a fmt integration test. 

    # Delete this line to force CI to run Clippy and the Rust tests.
[ci skip-rust-tests]
# Delete this line to force CI to run the JVM tests.
[ci skip-jvm-tests]
    @stuhood
    stuhood committed May 26, 2020
    Configuration menu
    Copy the full SHA
    339b850 View commit details
    Browse the repository at this point in the history

  3. Review feedback and test fix. 

    # Delete this line to force CI to run Clippy and the Rust tests.
[ci skip-rust-tests]
# Delete this line to force CI to run the JVM tests.
[ci skip-jvm-tests]
    @stuhood
    stuhood committed May 26, 2020
    Configuration menu
    Copy the full SHA
    4aeefb5 View commit details
    Browse the repository at this point in the history