Docker container and tsc
error TS2344
#571
Unanswered
andrii-lundiak
asked this question in
Q&A
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
@panva my work-related project relies on https://hub.docker.com/r/qlik/simple-oidc-provider and we use
0.2.4
version, meaning that our Dockerfile containsFROM qlik/simple-oidc-provider:0.2.4
. That version is year ago.We also have in
.env
:I also know there is https://hub.docker.com/r/rigon/node-openid-client which looks similar Docker image wrapping your package.
I am NOT good in this all as I want, BUT.
We also have NodeJS code setup, where we use
openid-client
, with^3.15.10
version. And before all was good.Then
dependanbot
suggested new5.4.0
version ofopenid-client
package. Fromdependabot
PR/code changes all looks OK, but when actual code we have tries to build (npx tsc
), it fails with TypeScript error:I will research more tomorrow (maybe it's my code), but maybe it hints your as maintainer of package.
BTW, we are on NodeJS
16.18.1
withts-node@9.0.0
,typescript@^4.3.5
and@types/node@^13.13.34
I tried also to upgrade
@types/node
to^16.11.5
version (as in ur package.json) although you have it as DEV dep, and it should NOT affect any end-customers/consumers code build. I also tried to upgrade@types/node
to latest version^18.13.0
Anyway both versions cause another error -
TS2339: Property 'sessionId' does not exist on type 'IncomingMessage'.
(sessionId
is taken fromreq
from Express server).Beta Was this translation helpful? Give feedback.
All reactions