Bumped lru cache to version 10 #674
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems like Erbium is an old node version. Maybe 12 or 14. I remember getting this error one year ago with Etherpad when the pipelines were on v12. |
|
I cannot bump the version of lru-cache without dropping support for older Node.js versions. That can only be done in semver-major update. I will obviously update all modules to their latest versions when I get the time to do a major release in the future but I don't have the capacity to finalize my plans for v6.x just yet. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should also resolve the issue we have with the different lru-cache dependencies:
ether/etherpad-lite#6330
All tests are passing