Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.2.1 #40

Merged
merged 35 commits into from
Sep 22, 2023
Merged

Release 1.2.1 #40

merged 35 commits into from
Sep 22, 2023

Conversation

kamarianakis
Copy link
Collaborator

No description provided.

papagiannakis and others added 30 commits July 29, 2023 20:44
Merge pull request #32 from kamarianakis/feature/fix_example_links
Merge pull request #34 from kamarianakis/feature/update_README
Merge pull request #33 from kamarianakis/feature/change_path_library
Enable Elements to work in Parallels Windows VM
Merge pull request #38 from kamarianakis/feature/updateREADME
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • replace the first sentence with the following in the description:
    This example demonstrates the ability to import basic USD files. By pressing the button load scene 3 red cubes are imported in the scene. Pressing button save scene the current scene is saved in usd format file.

  • Is the saved usd file correct?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested it to work: I moved a cube somewhere else, saved in a different file. Restarted the example, loaded the altered file, and the cubes were in the proper position. A limitation is that one has to restart the example, otherwise, it does not work, maybe we should put it in the description or as an issue ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this works for me also. The contents of the file do not look like usd.

Copy link
Collaborator

@aprotopsaltis aprotopsaltis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…description

Retouch description of import usd example
@kamarianakis kamarianakis merged commit 7b8c140 into main Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants