Simplify paths via pathlib #33
Conversation
There was a problem hiding this comment.
fine, but for consistency with the rest of the files use double quotes
There was a problem hiding this comment.
- double quotes here too
- I guess str() maybe removed just like the rest of the files
There was a problem hiding this comment.
os.path.join return a str by default, whereas the pathlib returns a possix filepath, which is not the same and therefore both pyassimp and usd load functions do not automatically make the change possix-->str, yielding an error. I will add a comment on the code to make it clear, thanks
There was a problem hiding this comment.
- is str() needed in load ?
- if not then remove and use " instead of single quotes
There was a problem hiding this comment.
fixed, see also comment above
There was a problem hiding this comment.
- is str() really needed in pyassimp.load ?
- for consistency, use " instead of single quotes
There was a problem hiding this comment.
fixed, added comment for str, moved it to separate line for clarity
There was a problem hiding this comment.
for consistency with the rest, create a variable atlasPath, using double quotes
Retouch most paths to use pathlib (less errors in various OS)
Removed redundant shader files