BMP v2 swd flashing issue fix for lisa mxs #2104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kevindehecker what is Lisa MXS? Did you mean Lisa S? https://wiki.paparazziuav.org/wiki/Lisa/S Edit: here is the correct wiki link: https://wiki.paparazziuav.org/wiki/Lisa/MXS_v1.0 Not much info there though. |
gautierhattenberger
requested changes
Aug 20, 2017
conf/maps_example.xml
Outdated
| @@ -1,3 +1,3 @@ | |||
| <!DOCTYPE maps SYSTEM "maps.dtd"> | |||
|
|
|||
| <maps google_version="733"/> | |||
| <maps google_version="129"/> | |||
There was a problem hiding this comment.
please don't change this file (you should rebase on master)
| BOARD_VERSION=1.0 | ||
| BOARD_CFG=\"boards/$(BOARD)_$(BOARD_VERSION).h\" | ||
|
|
||
| ARCH=stm32 |
There was a problem hiding this comment.
You're adding a lot of file related to ChibiOS, but still selecting the stm32 arch. And I don't think it is currently working without ChibiOS at the moment as some definition are missing. I think you should limit your pull request to adding the basic support of the lisa_mxs board and its flashing option, and add ChibiOS support later it needed when it is ready.
There was a problem hiding this comment.
Removed those files. I just copied it assuming it already worked.
|
This flashing options should also be the default for the lisa-s. It has the
same problem with BMPv2.
On Aug 20, 2017 22:50, "Gautier Hattenberger" <notifications@github.com> wrote:
*@gautierhattenberger* requested changes on this pull request.
------------------------------
In conf/maps_example.xml
<#2104 (comment)>:
@@ -1,3 +1,3 @@
<!DOCTYPE maps SYSTEM "maps.dtd">
-<maps google_version="733"/>
+<maps google_version="129"/>
please don't change this file (you should rebase on master)
------------------------------
In conf/boards/lisa_mxs_1.0.makefile
<#2104 (comment)>:
@@ -0,0 +1,28 @@
+# Hey Emacs, this is a -*- makefile -*-
+#
+# lisa_mxs_1.0.makefile
+#
+# https://wiki.paparazziuav.org/wiki/Lisa/MXS_v1.0
+#
+
+BOARD=lisa_mxs
+BOARD_VERSION=1.0
+BOARD_CFG=\"boards/$(BOARD)_$(BOARD_VERSION).h\"
+
+ARCH=stm32
You're adding a lot of file related to ChibiOS, but still selecting the
stm32 arch. And I don't think it is currently working without ChibiOS at
the moment as some definition are missing. I think you should limit your
pull request to adding the basic support of the lisa_mxs board and its
flashing option, and add ChibiOS support later it needed when it is ready.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#2104 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAd6fOrWwGCNsKpF1QUpC_7XdXWe6vrvks5saJwVgaJpZM4O76ll>
.
|
This required making a seperate board file for the mxs. Hence also changed the ladylisamxs airframe file to use the new board. Also added a cx10 airframe file.
kevindehecker
force-pushed
the
lisa_mxs_changes
branch
from
7ad5d63
to
71e47f4
Compare
gautierhattenberger
approved these changes
Aug 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made lisa mxs compatible with BMP v2 by disabling voltage sensing.
This required making a seperate board file for the mxs. Hence also changed the ladylisamxs airframe file to use the new board. Also added a cx10 airframe file.