Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[datalink] Set Xbee channel #2288

Merged
merged 3 commits into from Jul 3, 2018

Conversation

Fabien-B
Copy link
Contributor

Configure the xbee channel at modem initialization.
Use option -ch to change xbee channel.
Default is 0x0C.

@dewagter
Copy link
Member

Will it change the channel of the XBee if no option is given?

@Fabien-B
Copy link
Contributor Author

In the current implementation, yes. I hadn't thought about this.
I will change it to change xbee channel only when it is specified.

@dewagter
Copy link
Member

dewagter commented Jul 1, 2018

Great, thanks!

PS: what is the corresponding define to add to your airframe to change the airborne side?

@Fabien-B
Copy link
Contributor Author

Fabien-B commented Jul 1, 2018

In one of my airframes I have this line (for channel 0x17):
<define name="XBEE_INIT" value="\"ATID3332\rATCH17\rATP1\rATBD6\r\""/>
But I think this only necessary stuff is :
<define name="XBEE_INIT" value="\"ATCH17\r\""/>
I may add a tag to the telemetry configuration to make ot easier.

@dewagter
Copy link
Member

dewagter commented Jul 2, 2018

Thanks. Looks great. Info in config xml is also a good idea.

@gautierhattenberger
Copy link
Member

will merge after testing on hardware

@Fabien-B
Copy link
Contributor Author

Fabien-B commented Jul 2, 2018

Tested on hardware, it works !
The tests I made :
Aircraft on channel 0x10, modem on channel 0x0C:
launched without arguments : not working (as expected)
launched with arg -ch 0x10 : it works
Modem also on channel 0x10 , launched without argument : it works (so it don't change the channel if the argument is not given)

@gautierhattenberger gautierhattenberger merged commit fa2f603 into paparazzi:master Jul 3, 2018
@Fabien-B Fabien-B deleted the dev_xbee_set_channel branch July 3, 2018 08:34
biancabndris pushed a commit to biancabndris/paparazzi that referenced this pull request Aug 29, 2018
* [datalink] Adds Xbee channel configuration.
* Update pprzlink ref to include Xbee channel configuration.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants