Supervision tools #2350
Merged
Supervision tools #2350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gautierhattenberger
requested changes
Nov 5, 2018
|
Maybe the conversion script should be applied to the control_panel example file (and remove the corresponding section in the file) |
|
execution fails if directory |
|
I propose I run the script myself with the latest control_panel_example.xml, commit all the tool files, then remove the tools from the control_panel_example.xml (I will leave a commented custom configuration example). And maybe the script should not be part of this pull request |
…xml and write custom configuration example.
Fabien-B
force-pushed
the
supervision_tools
branch
from
47425c0
to
df302b2
Compare
…w one." This reverts commit 7cf89fb.
gautierhattenberger
approved these changes
Nov 14, 2018
|
@dewagter @podhrmic What do you think about this evolution ? The improvements are:
|
|
anyone for a comment of this modification ? |
|
Looks good! |
|
Looks good to me:-) |
shuoli-robotics
pushed a commit
to shuoli-robotics/paparazzi
that referenced
this pull request
Jan 23, 2019
The improvements: - it is easier to add new tools that will be immediately visible for the users - you can hide tools that you don't use - you can set different default using the control_panel file - it is backward compatible so you you don't change your current control_panel you keep every like before
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this PR is to move the tools configuration (partially) out of the control_panel.xml.
The default tool configuration will be in individual files (one for each tool) in conf/tools/.
You can then override the default configuration in your control_panel.xml (eg. to change the default arguments or add custom tools). You can also add the
blacklisted="true"attribute to the tools in your control_panel.xml to hide it in the paparazzi center.This way, you will be able to see the new tools without changing your control_panel.xml, and you can make a custom configuration without affecting the default one.