Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chibios] Add PX4FMU V4 (pixracer) #2394

Merged
merged 1 commit into from
Feb 26, 2019
Merged

Conversation

fvantienen
Copy link
Member

This adds support for the Pixracer (PX4FMU) using chibios.

kirkscheper
kirkscheper previously approved these changes Feb 22, 2019
Copy link
Member

@gautierhattenberger gautierhattenberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can check my small comments and I think it is good


#The GPS serial on px4 is called serial 3, but connected to uart4 on the f4
GPS_PORT ?= UART4
GPS_BAUD ?= B38400

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we can set a default speed of 57600 for recent board

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will change this

/**
* @brief SDC card detection.
*/
bool sdc_lld_is_card_inserted(SDCDriver *sdcp) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you have a SD card on this board, you probably need to implement this function like: https://github.com/paparazzi/paparazzi/blob/master/sw/airborne/boards/chimera/chibios/v1.0/board.c#L220

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I thought so as well, but these lines aren't connected on the pixracer so this is not possible. I looked at ardupilot and they have it like this and it works as well.

Copy link
Member

@gautierhattenberger gautierhattenberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@gautierhattenberger gautierhattenberger merged commit 4536f43 into master Feb 26, 2019
@gautierhattenberger gautierhattenberger deleted the px4fmu_chibi branch February 26, 2019 09:31
noether pushed a commit to noether/paparazzi that referenced this pull request Jun 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants