Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rotorcraft] don't reset vertical ref in guided mode #2418

Merged
merged 1 commit into from May 17, 2019

Conversation

gautierhattenberger
Copy link
Member

When calling the set_z or set_vz functions in guided mode, the reference
should not be called as it would make them ineffective when the control
rate is high

close #2410

When calling the set_z or set_vz functions in guided mode, the reference
should not be called as it would make them ineffective when the control
rate is high

close #2410
@fvantienen
Copy link
Member

@ls90911 Can you test this?

Copy link
Member

@dewagter dewagter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this. Shuo uses now: if not changed, then do not reset but I think this is better.

@gautierhattenberger gautierhattenberger merged commit 37cf050 into master May 17, 2019
@gautierhattenberger gautierhattenberger deleted the guided_vertical_ref branch May 17, 2019 08:26
noether pushed a commit to noether/paparazzi that referenced this pull request Jun 7, 2019
When calling the set_z or set_vz functions in guided mode, the reference
should not be called as it would make them ineffective when the control
rate is high

close paparazzi#2410
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vertical reference is wrong in guided mode
3 participants