Fixes PR #2475 #2478
Fixes PR #2475 #2478
Conversation
OpenUAS
added
conf
Enhancement
There was a problem hiding this comment.
This contains a lot of changes. They all look good to me, altough I do not understand why some lines had to be moved in the aka driver, and generally i prefer a few small pull requests: e.g. just the sonar correction, just the linux modules for bebop, etc in logical groups. And if it is important to set the dataready=true after the transmit, add some comment for the next person to change that code.
sw/airborne/peripherals/ak8963.c
Outdated
| i2c_transceive(ak->i2c_p, &(ak->i2c_trans), ak->i2c_trans.slave_addr, 1, 1); | ||
| ak->data_available = true; |
There was a problem hiding this comment.
New data flag should only be set to true one time. If you keep it here and then request the status to either reset it to true or false, you might either read the data twice or read false values. Before, the error flag was just ignored, we can change that but if should be consistent.
There was a problem hiding this comment.
Ok, thanks for looking into it. So I'll remove line 121 ( ak->data_available = true; ) is that correct what you request?
There was a problem hiding this comment.
CDW wrote:
This contains a lot of changes
Yeah, sorry, this comes since I set sub projects like e.g. "Make disco fly 100% using all useful sensor" then one comes across many issue, only flight testable often when multiple things are fixed. I'll see if in the future I'll can spit PR's. There are limited resources for PPRZ fixing and testflying things. This was Stage 2...
…parrot_disco_phase2
Made requested changes