Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[computer vision] Driver addition for mateksys_PMW3901_l0x #2655

Conversation

pcampolucci
Copy link
Contributor

follow up from #2639

Submodule of ppzlink updated to latest version

@pcampolucci
Copy link
Contributor Author

@gautierhattenberger this is the final one. Hope I did not forget anything

@gautierhattenberger
Copy link
Member

almost, pprzlink ref is good, but the key_generator submodule have been rewind to your backup branch version

@pcampolucci
Copy link
Contributor Author

ok done

@pcampolucci
Copy link
Contributor Author

@gautierhattenberger it fails again. It builds on my machine. I am out of ideas D:

@gautierhattenberger
Copy link
Member

I missed the modified ABI message, it has one extra parameter, so now it is failing with other modules using it:

 grep -r MsgOPTICAL_FLOW *
modules/computer_vision/opticflow_module.c:    AbiSendMsgOPTICAL_FLOW(FLOW_OPTICFLOW_ID, now_ts,
modules/sensors/opticflow_pmw3901.c:  AbiSendMsgOPTICAL_FLOW(FLOW_OPTICFLOW_PMW3901_ID,
modules/ctrl/optical_flow_landing.c:  AbiBindMsgOPTICAL_FLOW(OFL_OPTICAL_FLOW_ID, &optical_flow_ev, vertical_ctrl_optical_flow_cb);
modules/ctrl/optical_flow_hover.c:  AbiBindMsgOPTICAL_FLOW(OFH_OPTICAL_FLOW_ID, &optical_flow_ev, ofh_optical_flow_cb);
modules/stereocam/stereocam.c:    AbiSendMsgOPTICAL_FLOW(STEREOCAM2STATE_SENDER_ID, now_ts,

@pcampolucci
Copy link
Contributor Author

Oh these are new from the updated master, I will just remove the distance_quality parameter then. Its not that important

@pcampolucci
Copy link
Contributor Author

@gautierhattenberger It works!

Copy link
Member

@gautierhattenberger gautierhattenberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job

@gautierhattenberger gautierhattenberger merged commit 9230b50 into paparazzi:master Jan 30, 2021
@pcampolucci pcampolucci deleted the add_sensor_mateksys_PMW3901_VL53L0X branch January 31, 2021 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants