Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Place dummy waypoint inside max_dist_from_home. Fix #2693. #2694

Merged
merged 1 commit into from
Apr 12, 2021

Conversation

Fabien-B
Copy link
Contributor

No description provided.

@Fabien-B Fabien-B requested a review from dewagter April 12, 2021 07:41
@gautierhattenberger
Copy link
Member

What about placing this dummy WP at (0, 0) ? It is not supposed to be used anyway

@Fabien-B
Copy link
Contributor Author

Yep. Never understood why it exists anyway...
And semaphore is annoying...

@gautierhattenberger
Copy link
Member

This is indeed a good question, thank you for asking.

This dummy was added March 9th 2005 by Pascal with commit 27b5a45. It allows to use the go instruction with a WP id and if not found, to a (x, y) position with the x and y attributes, that are then stored in the dummy WP aforementioned.

However, on August 12th 2005, some indigent person named rad <USER@DOMAIN> removed the x and y attributes from the flight plan DTD on the reason that *** empty log message *** (see commit d696962), so the functionality still exists, but can't be used.

Of course, the temptation to curse this "rad" is great, but better keep the cleaning for after the coming release (so the day after tomorrow).

@gautierhattenberger gautierhattenberger merged commit 6a2af0b into paparazzi:master Apr 12, 2021
@Fabien-B Fabien-B deleted the dummy_waypoint branch April 12, 2021 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants