-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove static sectors #2701
Remove static sectors #2701
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fully agree, this also removes the problem with the correct orientation.
I also agree, but maybe one little thing: we should keep the DTD unchanged for some time and print a warning with a deprecated message when using |
I suggest making it an error, so people will take care of the problem before the DTD change. |
I agree with the error, this forces people to update their files. On a side note, shouldn't we list those deprecations somewhere with a specific enddate and a link to the specific code to remove/update. This reminds both the user and maintainers to update/remove this code. So my advice is to do the following:
|
Maybe we can use this github action, together with issues for that? |
For me that seems fine 👍 What do you think @gautierhattenberger ? |
we can give a try until github have a proper "due date" option for pull requests Here, we have also moved the definition of sectors outside the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine 👍
As suggested in #2677, I propose here to remove static sectors. All sector will be dynamic ones.