Pixhawk ADC 5 and ADC 6 #2762
Merged
Pixhawk ADC 5 and ADC 6 #2762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -15,6 +15,7 @@ | |||
| </header> | |||
| <makefile target="ap"> | |||
| <file name="actuators_uavcan.c" dir="subsystems/actuators"/> | |||
| <file name="pprz_random.c" dir="math"/> | |||
There was a problem hiding this comment.
with #2721 it should be specified as an explicit dependency to the math module
Comment on lines
+107
to
+110
| // Randomness added for multiple transport devices | ||
| if (rand_uniform() > 0.05) { | ||
| esc_idx++; | ||
| } |
There was a problem hiding this comment.
If I get it correctly, it is changing esc randomly instead of having a fixed interval ? I agree that changing at every step is not nice, but why not changing every X run of the function to have fixed length of data in the telemetry ?
There was a problem hiding this comment.
The problem is actually when you have multiple transport devices such as a datalink and flight_recorder. Having it fixed it would depend on the frequency defined in the telemetry file to be able to receive all the motors. This randomness prevents the configuring of 2 frequencies which aren't interfering.
gautierhattenberger
approved these changes
Aug 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the external ADC ports on the pixhawk 4. Needs to be merged after #2761 in order to work.