Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[replay] Use generated settings. #2767

Merged
merged 1 commit into from
Aug 24, 2021

Conversation

Fabien-B
Copy link
Contributor

Use "generated_settings" node instead of "settings" for replay settings.
Generate an empty node if not found.
According to #2569, "settings" node is "wrong", so its better if its not generated for replay.

Can you try it @OpenUAS to be sure it still works for you?

Copy link
Member

@gautierhattenberger gautierhattenberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot the last changes about settings in log file, better not use the old settings node, since it can be wrong even with older logs

@gautierhattenberger
Copy link
Member

tested and working

@gautierhattenberger gautierhattenberger merged commit ee9a185 into paparazzi:master Aug 24, 2021
@gautierhattenberger gautierhattenberger deleted the replay_settings branch August 24, 2021 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants