[ocaml] apply a second topological sort to modules #2793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After the first one, all functionalities are checked, but corresponding modules are not ordered with the other one. This second sorting algorithm (simpler) is just checking that final selection of modules is correctly ordered and check for possible cyclic dependencies not yet found. ahrs_common dep node is fixed to avoid such a situation.
the main issue is that the rotorcraft navigation is not explicitely included by the user but automagically included, which is not a good idea, same goes for guidance.
system_core is already provided by firmware module and @no_settings was making a cyclic dep for fbw
|
Note that the init order is only guaranteed within the same task, not for all modules across all tasks since the order of task is arbitrarily (yet wisely) chosen independently of the modules dependencies. |
Fabien-B
approved these changes
Nov 9, 2021
FlorianSan
pushed a commit
to enacuavlab/paparazzi
that referenced
this pull request
May 30, 2023
* [ocaml] apply a second topological sort to modules After the first one, all functionalities are checked, but corresponding modules are not ordered with the other one. This second sorting algorithm (simpler) is just checking that final selection of modules is correctly ordered and check for possible cyclic dependencies not yet found. ahrs_common dep node is fixed to avoid such a situation. * [modules] trying to fix cyclic dependency in rotorcraft gnc modules the main issue is that the rotorcraft navigation is not explicitely included by the user but automagically included, which is not a good idea, same goes for guidance. * [modules] fix dep system_core is already provided by firmware module and @no_settings was making a cyclic dep for fbw
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the first one, all functionalities are checked, but corresponding
modules are not ordered with the other one.
This second sorting algorithm (simpler) is just checking that final
selection of modules is correctly ordered and check for possible cyclic
dependencies not yet found.
ahrs_common dep node is fixed to avoid such a situation.