Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modules recommends and suggests #3005

Merged

Conversation

gautierhattenberger
Copy link
Member

Add two new items in module's dependency:

  • recommends: a recommended module tells the sorting algo that if the module is found, it should be sorted accordingly. It is useful for optional dependencies, like shell or mission in some modules
  • suggests: if a functionality is not provided by the user, a module can suggest a list of modules that can provide them. It is a convenient way to have "default" modules.

As a result the former autoload node is removed and replaced by suggested modules.

@gautierhattenberger gautierhattenberger marked this pull request as ready for review March 6, 2023 10:08
Copy link
Contributor

@Fabien-B Fabien-B left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, working.
It could be nice to print the recommended modules not used after the loaded modules. Something like:
'shell' recommended by 'sys_mon'

@gautierhattenberger gautierhattenberger merged commit 62646d6 into paparazzi:master Mar 7, 2023
@gautierhattenberger gautierhattenberger deleted the modules_recommend_and_suggest branch March 7, 2023 16:14
FlorianSan pushed a commit to enacuavlab/paparazzi that referenced this pull request May 30, 2023
Add two new items in module's dependency:
- recommends: a recommended module tells the sorting algo that if the module is found, it should be sorted accordingly. It is useful for optional dependencies, like shell or mission in some modules
- suggests: if a functionality is not provided by the user, a module can suggest a list of modules that can provide them. It is a convenient way to have "default" modules.

As a result the former autoload node is removed and replaced by suggested modules.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants