Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gvf for rotorcrafts #3197

Merged
merged 11 commits into from Dec 19, 2023

Conversation

spacewolfXfr
Copy link
Contributor

Add support in standard (non-parametric) GVF for rotorcrafts, by setting the nav variables appropriately.
Additionally, setup acceleration command in generic guidance for rotorcrafts.

@spacewolfXfr spacewolfXfr marked this pull request as ready for review December 8, 2023 09:53
Put default at the end of the switch, as it is customary
noether
noether previously requested changes Dec 8, 2023
sw/airborne/modules/guidance/gvf/gvf.c Outdated Show resolved Hide resolved
Copy link
Member

@gautierhattenberger gautierhattenberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be merged if tested in flight

@spacewolfXfr
Copy link
Contributor Author

  • Added the full chain from navigation acceleration to command to the controller using the standardized guidance_h,guidance_v interface.
  • Commented out WIP acceleration command in GVF, as not tested in flight nor proved
  • Synchronized changed made online (clearing out some comments)

sw/airborne/firmwares/rotorcraft/guidance/guidance_h.c Outdated Show resolved Hide resolved
sw/airborne/modules/guidance/gvf/gvf.c Outdated Show resolved Hide resolved
also address minor comments and code style
fvantienen
fvantienen previously approved these changes Dec 19, 2023
Copy link
Contributor Author

@spacewolfXfr spacewolfXfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validated in simulation (the aircraft no longer overshoot when switching between guidance modes)

@gautierhattenberger gautierhattenberger merged commit 6614729 into paparazzi:master Dec 19, 2023
1 check was pending
@gautierhattenberger gautierhattenberger deleted the gvf_for_rotorcrafts branch December 19, 2023 14:04
@dewagter dewagter mentioned this pull request Dec 20, 2023
2 tasks
gautierhattenberger added a commit that referenced this pull request Feb 6, 2024
After #3197, the functions guidance_h_set_xxx are reseting the state so
it creates inconsistent behavior when abusing the 'set_pos' to update
the gcs display.
gautierhattenberger added a commit that referenced this pull request Feb 7, 2024
After #3197, the functions guidance_h_set_xxx are reseting the state so
it creates inconsistent behavior when abusing the 'set_pos' to update
the gcs display.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants