Support for TawakiV2 (STM32H7)

[Fabien-B]

No description provided.

[fvantienen]

What about the defines in mcuconf.h is this not enough for you to set the nocache regions?:

 * Memory attributes settings.
 */
#define STM32_NOCACHE_ENABLE                TRUE
#define STM32_NOCACHE_MPU_REGION            MPU_REGION_6
#define STM32_NOCACHE_RBAR                  0x24000000U
#define STM32_NOCACHE_RASR                  MPU_RASR_SIZE_64K

Because I prefer to keep it then the same for every board, either we do it ourselves or use the ChibiOS features to set the MPU.

Next to that your tawaki_v2.0.h is almost the same as the common_board.h. Isn't it better to change the names in board.cfg such that common_board.h can be used and the features that are missing can be added there?

These are just some suggestions, but I really like the fixes that you have done :)

[Fabien-B]

I will try looking into your suggestions, but it may not be easy.
First annoying thing:

common_board.h:

#define LED_1_GPIO_ON     gpio_clear
#define LED_1_GPIO_OFF    gpio_set

tawaki_v2.0.h:

#define LED_1_GPIO_ON     gpio_set
#define LED_1_GPIO_OFF    gpio_clear

[fvantienen]

I will try looking into your suggestions, but it may not be easy. First annoying thing:

common_board.h:

#define LED_1_GPIO_ON     gpio_clear
#define LED_1_GPIO_OFF    gpio_set

tawaki_v2.0.h:

#define LED_1_GPIO_ON     gpio_set
#define LED_1_GPIO_OFF    gpio_clear

Maybe a good solution for that would be to define NLED1 as a name in the cfg file or something like that to indicate it is inverted.

[alex31]

What about the defines in mcuconf.h is this not enough for you to set the nocache regions?:

 * Memory attributes settings.
 */
#define STM32_NOCACHE_ENABLE                TRUE
#define STM32_NOCACHE_MPU_REGION            MPU_REGION_6
#define STM32_NOCACHE_RBAR                  0x24000000U
#define STM32_NOCACHE_RASR                  MPU_RASR_SIZE_64K

Because I prefer to keep it then the same for every board, either we do it ourselves or use the ChibiOS features to set the MPU.

Next to that your tawaki_v2.0.h is almost the same as the common_board.h. Isn't it better to change the names in board.cfg such that common_board.h can be used and the features that are missing can be added there?

These are just some suggestions, but I really like the fixes that you have done :)

The H7 provides 3 different domains, and we need "nocache" regions in 2 regions, to support all of our dma bound peripherals. Chibios mechanism permit to define only one region via mcuconf.h.
We define 2 regions in our custom code, so STM32_NOCACHE_ENABLE should be set to FALSE in mcuconf.h

[gautierhattenberger]

Can be merged once tested in flight

[Fabien-B]

Tested multiple times, it works.