Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flightplans] tudelft flightplans #3220

Merged
merged 2 commits into from
Dec 22, 2023
Merged

[flightplans] tudelft flightplans #3220

merged 2 commits into from
Dec 22, 2023

Conversation

dewagter
Copy link
Member

@dewagter dewagter commented Dec 19, 2023

@Fabien-B new GCS not working well with includes : tudelft-conf - rotwing3D -> xmlParseEntityRef on exception

@Fabien-B
Copy link
Contributor

@dewagter Oh yeah, I remember Gautier told me that.
I will try looking into it, but I'm quite annoyed by how we handle the configuration files at the moment : in my opinion, all this handling of the configuration files should be done by the server. We should being able to query it to have the full airframe file, with the include resolved.
Same thing for the flight plans with the procedures, that are not working neither in the new GCS at the moment.
I wanted to do that but I was discouraged by how much work is needed to replace the current server.
Maybe I can start small and just do the merging of the configuration files ?

@dewagter
Copy link
Member Author

A simple text include preprocessor would do what is needed better than the procedure.

@dewagter dewagter marked this pull request as ready for review December 21, 2023 13:48
@dewagter
Copy link
Member Author

Unable to split.

Option 1: separate wp files with common blocks fails in GCS
Option 2: common flightplan including separate wp files has wrong origin (WP to far from HOME) and needs to be modified by hand every time.
Option 3: separate full flightplans which are often synced with difftools -> selected option.

@dewagter
Copy link
Member Author

@Dennis-Wijngaarden changed GetPosAlt to GetPosHeight

@dewagter dewagter changed the title Split flightplan attempt [flightplans] tudelft flightplans and coverity test fix Dec 21, 2023
@dewagter dewagter changed the title [flightplans] tudelft flightplans and coverity test fix [flightplans] tudelft flightplans Dec 22, 2023
@dewagter dewagter merged commit 78c3ff3 into master Dec 22, 2023
@dewagter dewagter deleted the split_flightplan_attempt branch December 22, 2023 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants