Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[conf] update Enac rotorcraft so that they work in simulation as well #3235

Merged
merged 1 commit into from
Feb 7, 2024
Merged

[conf] update Enac rotorcraft so that they work in simulation as well #3235

merged 1 commit into from
Feb 7, 2024

Conversation

gautierhattenberger
Copy link
Member

  • update Enac rotorcraft airframes
  • remove dead aircraft
  • add jsbsim model files
  • update bebop2 example

@gautierhattenberger
[conf] update Enac rotorcraft so that they work in simulation as well
821b491 
- update Enac rotorcraft airframes
- remove dead aircraft
- add jsbsim model files
- update bebop2 example
dewagter
dewagter reviewed Feb 6, 2024
View reviewed changes
Copy link
Member

@dewagter dewagter left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning up. Nice to be able to simulate all airframes.

  • PS: what is the status of dshot? Is it set to 300 by default?

conf/airframes/ENAC/quadrotor/anton_indi_aruco.xml Show resolved Hide resolved
conf/airframes/ENAC/quadrotor/anton_indi_aruco.xml Show resolved Hide resolved
conf/airframes/examples/bebop2_indi.xml Show resolved Hide resolved
@gautierhattenberger
Copy link
Member Author

Normal DShot is working and the default is set to 300. With 600 some ESC can have troubles (and 1200 is officially removed from the specs).
We are still working on the bidirectional dshot with test code that is working and that should be ported to Paparazzi.

@dewagter
Copy link
Member

dewagter commented Feb 7, 2024

Normal DShot isNormal DShot is working and the default is set to 300. With 600 some ESC can have troubles (and 1200 is officially removed from the specs). We are still working on the bidirectional dshot with test code that is working and that should be ported to Paparazzi.

Is that #2717 ?

dewagter
dewagter approved these changes Feb 7, 2024
View reviewed changes
Copy link
Member

@dewagter dewagter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gautierhattenberger
Copy link
Member Author

Normal DShot isNormal DShot is working and the default is set to 300. With 600 some ESC can have troubles (and 1200 is officially removed from the specs). We are still working on the bidirectional dshot with test code that is working and that should be ported to Paparazzi.

Is that #2717 ?

No. I need to check, but maybe this PR is not relevant anymore.

@gautierhattenberger gautierhattenberger merged commit 2ae4fed into paparazzi:master Feb 7, 2024
1 check passed
@gautierhattenberger gautierhattenberger deleted the enac_conf_update branch February 7, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dewagter dewagter dewagter approved these changes

@Fabien-B Fabien-B Awaiting requested review from Fabien-B

Assignees
No one assigned
Labels
conf
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gautierhattenberger @dewagter