Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vl53l5cx driver. Based on St ULD. #3240

Merged
merged 5 commits into from
Feb 29, 2024
Merged

Add vl53l5cx driver. Based on St ULD. #3240

merged 5 commits into from
Feb 29, 2024

Conversation

Fabien-B
Copy link
Contributor

Driver for 8x8 range sensor VL53L5CX.
Based on St ULD.

Also fix some errors in tawakiV2 board.

@gautierhattenberger
Copy link
Member

I think you also need to specify the correct arch attribute for the test node

@Fabien-B
Copy link
Contributor Author

Fabien-B commented Feb 20, 2024

I think you also need to specify the correct arch attribute for the test node

Adding arch to the test did not help to pass the test. Its because the compiled file is not arch dependent, but the included file is.
I don't known exactly how the build system is working, but I think the problem come from the test.

@gautierhattenberger
Copy link
Member

You can try to include modules/lidar/vl53l5cx_platform.h, since the include path in test script it arch/<arch_name> (https://github.com/paparazzi/paparazzi/blob/master/tests/modules/test_modules.py#L148)

@Fabien-B
Copy link
Contributor Author

Not working, because it's a file, and not a file_arch.

@fvantienen
Copy link
Member

Can we merge the i2c fixes sooner?

@gautierhattenberger
Copy link
Member

The i2c modification is not really a bug fix, but more like a hack to use the i2c from a thread with active way by skipping the normal transaction queue. So for the long term I would even prefer an other option, but we'll see. The reasons for the test to file are identified, we just need to move some code and files. It should be done soon.

@Fabien-B Fabien-B merged commit ae5f47a into master Feb 29, 2024
1 check passed
@Fabien-B Fabien-B deleted the vl53l5cx branch February 29, 2024 09:46
Dennis-Wijngaarden pushed a commit to tudelft/paparazzi that referenced this pull request Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants