added compressed remote GPS message for limited datalinks #14
Conversation
| @@ -1997,7 +1999,24 @@ | |||
| <field name="imageBuffer" type="uint8[]"/> | |||
| </message> | |||
|
|
|||
| <!--230 is free --> | |||
| <message name="SWARMNN" id="230"> | |||
There was a problem hiding this comment.
Can you please add descriptions (for the message as well as the fields) and add units?
| @@ -2223,6 +2248,7 @@ | |||
| <field name="utm_east" type="int32" unit="cm"></field> | |||
| <field name="utm_north" type="int32" unit="cm"></field> | |||
| <field name="alt" type="int32" unit="cm">Height above Mean Sea Level (geoid)</field> | |||
| <field name="utm_zone" type="int8"></field> | |||
There was a problem hiding this comment.
still think this should be uint8_t
|
validation failed, please fix wrong field close tags |
|
I get a bunch of unaligned message errors when I make the messages in a test (in messages that are already in the code). Shall I move the message items around to correct that or is it not an issue? |
|
what test and what messages? |
|
never mind, ends up that the intermcu is not possible to be aligned |
|
There is also too much stuff in one commit/PR that makes it really hard to merge only some of your other pull requests... |
|
I don't want the ac_id removed, I just moved it to the end of the message to stop the not aligned error when that is important. The branch looks good, pull it!. |
|
For the RSSI message, should it get some field to indicate where the RSSI is from? |
|
Yea, I guess you could do that, I use it now to communicate the rssi Kirk
|
|
I was more thinking about different components on the aircraft reporting RSSI, but if we don't need that right now, maybe we better wait until we add a component id to all messages? |
| <field name="multiplex_speed" type="uint32">bits 31-21 course in decideg : bits 20-10 ground speed in cm/s : bits 9-0 climb speed in cm/s</field> | ||
| <field name="lla_lat" type="int32" unit="1e7deg" alt_unit="deg" alt_unit_coef="0.0000001"></field> | ||
| <field name="lla_lon" type="int32" unit="1e7deg" alt_unit="deg" alt_unit_coef="0.0000001"></field> | ||
| <field name="alt" type="int16" unit="cm" alt_unit="m" alt_unit_coef="0.01"></field> |
There was a problem hiding this comment.
This is supposed to be alt above MSL(geoid) or ellipsoid?
|
Added the RSSI message with ab69fa7 |
kirkscheper
changed the title
|
I removed the swarm message for now, in the end I am not sure this will be useful for others. The compressed message may be useful though... |
|
|
||
| <message name="GPS_SMALL" id="252"> | ||
| <field name="multiplex_speed" type="uint32">bits 31-21 course in decideg : bits 20-10 ground speed in cm/s : bits 9-0 climb speed in cm/s</field> | ||
| <field name="lla_lat" type="int32" unit="1e7deg" alt_unit="deg" alt_unit_coef="0.0000001"></field> |
There was a problem hiding this comment.
as already mentioned in the other PR, I think it makes sense to keep the lat and lon field names like in all the other messages or is there a reason for naming them lla_lat and lla_lon here?
Same for ACINFO_LLA
kirkscheper
force-pushed
the
swarm
branch
2 times, most recently
from
078f82a
to
a8d44be
Compare
| <field name="heading" type="int16" unit="1e4rad" alt_unit="rad" alt_unit_coef="0.0001"/> | ||
| <field name="pos_xyz" type="uint32">bits 31-21 x position in cm : bits 20-10 y position in cm : bits 9-0 z position in cm</field> | ||
| <field name="speed_xyz" type="uint32">bits 31-21 speed x in cm/s : bits 20-10 speed y in cm/s : bits 9-0 speed z in cm/s</field> | ||
| <field name="tow" type="uint32" unit="ms" alt_unit="s" alt_unit_coef="1000."/> |
|
LGTM |
Re-purposed the WC_RSSI message (which appeared not be be used).
updated remote_gps to be fowarded.
added a very small gps message and a swarming message.