This repository has been archived by the owner on Jan 11, 2018. It is now read-only.
flake8 the project on test #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The reason coverage decreased was because I decided to not exclude webdriver.py from coverage |
| @@ -2,6 +2,9 @@ machine: | |||
| python: | |||
| version: 2.7.6 | |||
|
|
|||
| dependencies: | |||
| override: | |||
| - pip install tox | |||
There was a problem hiding this comment.
tox is already declared in setup.py as a thing required by the tests. If you run the tests as python setup.py test (which CircleCI does by default I bet, if you don't override it below), then your test dependencies will get installed automatically.
There was a problem hiding this comment.
I was getting some whacky behavior where it wasn't respecting my tox.ini until I specifically overrode the dependency behavior.
- `make test` and `tox` will now run flake8 first - make changes to the project so flake8 will pass Closes #2
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make testandtoxwill now run flake8 firstCloses #2
@tmillner @bitglue