Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User dev plugin fails on prepareKotlinBuildScriptModel #64

Closed
yannicklamprecht opened this issue Aug 18, 2021 · 4 comments
Closed

User dev plugin fails on prepareKotlinBuildScriptModel #64

yannicklamprecht opened this issue Aug 18, 2021 · 4 comments
Labels
good first issue Good for newcomers status: accepted Issue is accepted and we want to address it type: bug Something isn't working

Comments

@yannicklamprecht
Copy link

Currently the userdev plugin fails because the diff option --color=never is not recognized by the present diff cli tool.
In every patch in the directory .gradle/caches/paperweight/setupCache/extractDevBundle.dir/patches/ the following is printed.

diff: unrecognized option --color=never' diff: Try diff --help' for more information.

I probably can fix that myself by installing a diff tool the support this color parameter but it could be a big issue for others.
Additionally it tries to apply package-info patches which aren't present here.

Command finished with 128 exit code: git -c commit.gpgsign=false -c core.safecrlf=false apply /Users/myUser/gitWorldBorderAPI/.gradle/caches/paperweight/setupCache/extractDevBundle.dir/patches/net/minecraft/package-info.java.patch Command finished with 128 exit code: git -c commit.gpgsign=false -c core.safecrlf=false apply /Users/myUser/git/WorldBorderAPI/.gradle/caches/paperweight/setupCache/extractDevBundle.dir/patches/net/minecraft/package-info.java.patch

@Proximyst
Copy link
Contributor

https://ss64.com/osx/diff.html

macOS does not have --color in its diff command. Would be too sensible 😉.
As a workaround, install GNU/diff.

@Proximyst Proximyst added status: accepted Issue is accepted and we want to address it type: bug Something isn't working good first issue Good for newcomers labels Aug 18, 2021
@jpenilla
Copy link
Member

Currently the userdev plugin fails because the diff option --color=never is not recognized by the present diff cli tool.
In every patch in the directory .gradle/caches/paperweight/setupCache/extractDevBundle.dir/patches/ the following is printed.

No, the userdev plugin does not use diff. This is core/patcher generating the dev bundle. Dev bundle generation is a much lower priority for working on every platform than the rest of paperweight as the bundle is meant to be generated by CI and published to a maven repo, not built locally.

As proxi said, generating the dev bundle requires GNU diff, so this is not a bug but a feature request to rework patch generation to not use GNU diff. I've opened a separate issue for that: #65

The package-info issue is a separate thing and does sound like a bug, however the dev bundle on the Paper repo (and ones I generate locally) do not have package-info patches, so it seems more like you have an invalid dev bundle? What dev bundle were you using to get this error?

@yannicklamprecht
Copy link
Author

Seems like I missinterpreted your example projects workflow. That was present 16+ hours ago.

I'll nuke the user dev bundle in my local maven repository and report back.

I should stop using bleeding edge projects.

@yannicklamprecht
Copy link
Author

Yeah works after nuking the part and cleaning the setup. https://github.com/yannicklamprecht/WorldBorderAPI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers status: accepted Issue is accepted and we want to address it type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants