Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metrics for dropped outgoing messages #10223

Closed
mattsse opened this issue Aug 8, 2024 · 5 comments · Fixed by #10225
Closed

Add metrics for dropped outgoing messages #10223

mattsse opened this issue Aug 8, 2024 · 5 comments · Fixed by #10225
Assignees
Labels
A-observability Related to tracing, metrics, logs and other observability tools C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started

Comments

@mattsse
Copy link
Collaborator

mattsse commented Aug 8, 2024

Describe the feature

session channels are bounded, if there's no capacity, the message will be dropped:

let _ = session.commands_to_session.try_send(SessionCommand::Message(msg));

it would be nice to have a counter for when this happens

pub struct SessionManagerMetrics {

TODO

  • add new metrics counter, increase if the message couldn't be delivered

Additional context

No response

@mattsse mattsse added C-enhancement New feature or request S-needs-triage This issue needs to be labelled labels Aug 8, 2024
@mattsse mattsse added D-good-first-issue Nice and easy! A great choice to get started A-observability Related to tracing, metrics, logs and other observability tools and removed S-needs-triage This issue needs to be labelled labels Aug 8, 2024
@nkysg
Copy link
Contributor

nkysg commented Aug 8, 2024

Please assign me.

@malik672
Copy link
Contributor

malik672 commented Aug 8, 2024

Please assign me.

you should add the tag

@nkysg
Copy link
Contributor

nkysg commented Aug 8, 2024

Please assign me.

you should add the tag

I have no permissions to add the tag.

@mattsse
Copy link
Collaborator Author

mattsse commented Aug 8, 2024

cool, thanks @nkysg, please always simply comment, otherwise github doesn't let me assign...

@nkysg
Copy link
Contributor

nkysg commented Aug 8, 2024

@mattsse got it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-observability Related to tracing, metrics, logs and other observability tools C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants