Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature req: Need logIndex in type CallLogFrame when invoke API debug_trace* #10258

Closed
hitdavid opened this issue Aug 11, 2024 · 4 comments
Closed
Labels
C-enhancement New feature or request S-needs-triage This issue needs to be labelled S-stale This issue/PR is stale and will close with no further activity

Comments

@hitdavid
Copy link

Describe the feature

When you add tracerConfig: { withLog: true } , The result of Calls like debug_traceXXX will return log index (index inner tx) inside callframe logs array to make clear of the sequence of logs.
Erigon and other nodes support this feature. It is a very useful feature. It's a strong feature to let Apps migrate from Erigon to reth. Consider add this feature please.

Additional context

No response

@hitdavid hitdavid added C-enhancement New feature or request S-needs-triage This issue needs to be labelled labels Aug 11, 2024
@jsvisa
Copy link
Contributor

jsvisa commented Aug 12, 2024

I think what you want is the position field in Geth's, ref ethereum/go-ethereum#28389 this field is a little differ to logIndex in other places, so I prefer position over logIndex)

I'll implement this feature by backporting from Geth's.

@hitdavid
Copy link
Author

GREAT! thanks a lot

Copy link
Contributor

This issue is stale because it has been open for 21 days with no activity.

@github-actions github-actions bot added the S-stale This issue/PR is stale and will close with no further activity label Sep 13, 2024
@mattsse
Copy link
Collaborator

mattsse commented Sep 13, 2024

we added position in the recent release ty @jsvisa

@mattsse mattsse closed this as completed Sep 13, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement New feature or request S-needs-triage This issue needs to be labelled S-stale This issue/PR is stale and will close with no further activity
Projects
Archived in project
Development

No branches or pull requests

3 participants