Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PayloadBuilder Implementation that supports two types of builders #10438

Closed
Tracked by #10435
mattsse opened this issue Aug 22, 2024 · 7 comments · Fixed by #11004
Closed
Tracked by #10435

Add PayloadBuilder Implementation that supports two types of builders #10438

mattsse opened this issue Aug 22, 2024 · 7 comments · Fixed by #11004
Labels
A-block-building Related to block building C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started S-stale This issue/PR is stale and will close with no further activity

Comments

@mattsse
Copy link
Collaborator

mattsse commented Aug 22, 2024

The PayloadBuilder trait defines the interface for a basic payloadbuilder:

pub trait PayloadBuilder<Pool, Client>: Send + Sync + Clone {

it would be nice if we would have a type that supports two kinds of builders:

struct PayloadBuilderStack<L,R> {}

this way we could easily integrate multiple builder types, e.g. rpc pending block and regular CL

@mattsse mattsse added C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started A-block-building Related to block building labels Aug 22, 2024
@tolu0x
Copy link

tolu0x commented Aug 22, 2024

@mattsse assign me

@garwahl
Copy link
Contributor

garwahl commented Aug 28, 2024

Hey @tolu0x are you still working on this? Happy to pick this up as I'm doing some work with PayloadBuilder at the moment

@tolu0x
Copy link

tolu0x commented Aug 28, 2024

Hey @garwahl, i've not been able to complete my implementation due to my exams. If you can take it on, i'd be delighted to see your solution. LGTM

@nkysg
Copy link
Contributor

nkysg commented Aug 30, 2024

@garwahl first. If no one try, I want to try.

@mattsse mattsse assigned nkysg and unassigned tolu0x Aug 30, 2024
@nkysg
Copy link
Contributor

nkysg commented Aug 31, 2024

The PayloadBuilder trait defines the interface for a basic payloadbuilder:

pub trait PayloadBuilder<Pool, Client>: Send + Sync + Clone {

it would be nice if we would have a type that supports two kinds of builders:

struct PayloadBuilderStack<L,R> {}

this way we could easily integrate multiple builder types, e.g. rpc pending block and regular CL

I'm not really geting about two kinds of builders. I just see EthereumPayloadBuilder and OptimismPayloadBuilder. Is it right @mattsse ?

Copy link
Contributor

This issue is stale because it has been open for 21 days with no activity.

@github-actions github-actions bot added the S-stale This issue/PR is stale and will close with no further activity label Oct 12, 2024
Copy link
Contributor

This issue was closed because it has been inactive for 7 days since being marked as stale.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 19, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-block-building Related to block building C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started S-stale This issue/PR is stale and will close with no further activity
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants