Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change BodiesClient interface to accept Vec<H256> instead of single H256 #247

Closed
mattsse opened this issue Nov 24, 2022 · 0 comments · Fixed by #257
Closed

Change BodiesClient interface to accept Vec<H256> instead of single H256 #247

mattsse opened this issue Nov 24, 2022 · 0 comments · Fixed by #257

Comments

@mattsse
Copy link
Collaborator

mattsse commented Nov 24, 2022

the current trait expects a 1:1 hash:Body relationship, however the network request accepts Vec<H256>

Ref #226

having Vec<H256> in place makes it easier to go from 1 to many without breaking a lot of interfaces
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: bodies client API paradigmxyz/reth
1 participant
@mattsse