Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add redundant_pub_crate = "warn" clippy lint #8564

Closed
tcoratger opened this issue Jun 3, 2024 · 2 comments
Closed

Add redundant_pub_crate = "warn" clippy lint #8564

tcoratger opened this issue Jun 3, 2024 · 2 comments
Labels
C-enhancement New feature or request S-needs-triage This issue needs to be labelled

Comments

@tcoratger
Copy link
Contributor

Describe the feature

At the moment, redundant_pub_crate clippy lint is allowed

reth/Cargo.toml

Line 174 in 994f98f

redundant_pub_crate = "allow"

It seems it has quite a lot of findings inside the codebase. It could be useful to activate a warn for this one.

Additional context

No response
@tcoratger tcoratger added C-enhancement New feature or request S-needs-triage This issue needs to be labelled labels Jun 3, 2024
@mattsse
Copy link
Collaborator

mattsse commented Jun 3, 2024

hmm, pub crate functions are not accessible by other crates, I don't think this lint is very useful

@mattsse
Copy link
Collaborator

mattsse commented Jun 15, 2024

this would be very noisy

@mattsse mattsse closed this as not planned Won't fix, can't repro, duplicate, stale Jun 15, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Jun 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-enhancement New feature or request S-needs-triage This issue needs to be labelled
Projects
Reth Tracker
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mattsse @tcoratger