Skip to content
This repository has been archived by the owner on Oct 6, 2021. It is now read-only.

Invalid CSRF token results in notice #41

Closed
kelunik opened this issue Jun 28, 2016 · 2 comments
Closed

Invalid CSRF token results in notice #41

kelunik opened this issue Jun 28, 2016 · 2 comments
Labels
bug papercut technical debt

Comments

@kelunik
Copy link
Contributor

kelunik commented Jun 28, 2016

https://github.com/paragonie/airship/blob/master/src/Engine/Security/CSRF.php#L123 will raise a notice if there's no : (colon) in the provided token. It's rejected, but clean code shouldn't throw any notices.
paragonie-security added a commit that referenced this issue Jun 28, 2016
@paragonie-security
Don't raise E_NOTICE on list(). Thanks @kelunik
3b620cc 
See #41
@paragonie-scott
Copy link
Member

Absolutely. Thanks for looking through the code. This commit should fix any list()-based notices: 3b620cc

@kelunik
Copy link
Contributor Author

kelunik commented Jun 28, 2016

Can we close this then?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug papercut technical debt
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kelunik @paragonie-scott