New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid CSRF token results in notice #41

Closed
kelunik opened this Issue Jun 28, 2016 · 2 comments

Comments

Projects
None yet
2 participants
@kelunik
Contributor

kelunik commented Jun 28, 2016

https://github.com/paragonie/airship/blob/master/src/Engine/Security/CSRF.php#L123 will raise a notice if there's no : (colon) in the provided token. It's rejected, but clean code shouldn't throw any notices.

@paragonie-scott

This comment has been minimized.

Show comment
Hide comment
@paragonie-scott

paragonie-scott Jun 28, 2016

Member

Absolutely. Thanks for looking through the code. This commit should fix any list()-based notices: 3b620cc

Member

paragonie-scott commented Jun 28, 2016

Absolutely. Thanks for looking through the code. This commit should fix any list()-based notices: 3b620cc

@kelunik

This comment has been minimized.

Show comment
Hide comment
@kelunik

kelunik Jun 28, 2016

Contributor

Can we close this then?

Contributor

kelunik commented Jun 28, 2016

Can we close this then?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment