Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide the "Don't Save" button when discarding a file isn't a desired behavior #247

Closed
phated opened this issue Aug 29, 2015 · 2 comments · Fixed by #263
Closed

Hide the "Don't Save" button when discarding a file isn't a desired behavior #247

phated opened this issue Aug 29, 2015 · 2 comments · Fixed by #263
Assignees
@urbantumbleweed
Labels
Bug Priority 2
Milestone
Sprint 10

Comments

@phated
Copy link
Contributor

phated commented Aug 29, 2015

Currently, if a file is a brand new (unsaved) file, the Save/Save As prompt has a "Don't Save" button. This is desired when a user attempts to change from a new file to a previously saved file and is prompted to save. However, this is incorrect UI behavior when the user is just using the Save/Save As functionality of the editor. We need to hide the "Don't Save" button when we are not in the "Changing File" mode.
@phated phated added the Bug label Aug 29, 2015
@PropGit
Copy link
Contributor

PropGit commented Aug 29, 2015

NOTE: This is a new behavior (bug) in v0.7.1; it did not behave this way in v0.7.0 as you can see about 20 seconds into this video that was recorded for issues #235.

It seems to only happen incorrectly when it is a new file and either the Save or Save As operation is user-activated. After it is saved, an Save As operation shows the right dialog (with no "Don't Save" button).

@urbantumbleweed urbantumbleweed modified the milestone: Sprint 10 Sep 1, 2015
@monteslu monteslu assigned urbantumbleweed and unassigned monteslu Sep 12, 2015
urbantumbleweed added a commit that referenced this issue Sep 12, 2015
@urbantumbleweed
added a another case to overlays to account hide the 'don't save' but…
051a228 
…ton. closes #247
@urbantumbleweed urbantumbleweed mentioned this issue Sep 12, 2015
Merged
urbantumbleweed added a commit that referenced this issue Sep 14, 2015
@urbantumbleweed
added a another case to overlays to account hide the 'don't save' but…
c1b4f43 
…ton. closes #247
phated added a commit that referenced this issue Sep 14, 2015
@phated
Merge pull request #263 from parallaxinc/remove-dont-save-button-on-c…
5c339d2 
…hange-file

Hide the 'don't save' button when in change mode. closes #247
@PropGit
Copy link
Contributor

PropGit commented Sep 16, 2015

Verified fixed. However, this has led to a side effect noted in issue #268.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@urbantumbleweed urbantumbleweed

Labels
Bug Priority 2
Projects
None yet
Milestone
Sprint 10
Development

Successfully merging a pull request may close this issue.

Hide the 'don't save' button when in change mode. closes #247 parallaxinc/Parallax-IDE
4 participants
@monteslu @phated @PropGit @urbantumbleweed