Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

start session on the last file accessed - closes #89 #99

Merged
merged 1 commit into from
May 21, 2015

Conversation

phated
Copy link
Contributor

@phated phated commented May 21, 2015

What's this PR do?

Saves the last accessed file into user config and opens it upon startup.

Where should the reviewer start?

plugins/sidebar/index.js defines a loadFile function that is passed to multiple components that have some way to open a file.

How should this be manually tested?

Verify that clicking a file, using keyboard shortcuts to switch files and creating a file all save the newly-opened file into user config and is displayed upon startup.

Any background context you want to provide?

The functionality was spread across multiple components so I created a function that could be passed to each. This could probably be cleaned up with a flux-like architecture.

What are the relevant tickets?

Closes #89

2fast2fourier added a commit that referenced this pull request May 21, 2015
start session on the last file accessed - closes #89
@2fast2fourier 2fast2fourier merged commit 1d1af48 into master May 21, 2015
@2fast2fourier 2fast2fourier deleted the open-last-file branch May 21, 2015 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Start session where last left off
2 participants