Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusion in usage and documentation of query parameters for transactions api in v5 #103

Open
cchighman opened this issue Feb 5, 2022 · 0 comments

Comments

@cchighman
Copy link

I'm not really sure of the use case and decision behind making the transactions API do a GET operation with a POST call. Provided two layers of parameters, those for use in the body and others for use as query parameters further adds confusion since POST requests traditionally do not use query parameters. To illustrate how its easy to be confused, in the below screenshot you will see that I have included the query parameters for "ignoreChecks" yet the API still informed me I dont have enough for the transaction. This was because, by default, I put the "ignoreChecks" parameter in the body payload as well and forgot about it. If you include the ignoreChecks parameter in both the querystring and body, it will no longer consider the fact its included in the querystring. This is a bug and has room for improvement.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant