Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Runtime error in production build of ReasonML app #1638

Closed
alex35mil opened this issue Jun 29, 2018 · 4 comments
Closed

Runtime error in production build of ReasonML app #1638

alex35mil opened this issue Jun 29, 2018 · 4 comments
Labels

Comments

@alex35mil
Copy link

alex35mil commented Jun 29, 2018

🐛 bug report

After bump from 1.8.1 to 1.9.3 I receive runtime errors in Reason app in production build only.

🎛 Configuration (.babelrc, package.json, cli command)

package.json: https://github.com/alexfedoseev/re-formality/blob/bump-parcel/package.json
bsconfig.json: https://github.com/alexfedoseev/re-formality/blob/bump-parcel/bsconfig.json
No babel.

🤔 Expected Behavior

No runtime errors.

😯 Current Behavior

Uncaught TypeError: Cannot read property 'ReactCurrentOwner' of undefined
    at Object.parcelRequire.38.fbjs/lib/invariant (examples.19edb846.js:109)
    at u (examples.19edb846.js:1)
    at p (examples.19edb846.js:1)
    at Object.parcelRequire.34../cjs/react-dom.production.min.js (examples.19edb846.js:111)
    at u (examples.19edb846.js:1)
    at p (examples.19edb846.js:1)
    at Object.parcelRequire.32../Formality__Validation.bs.js (examples.19edb846.js:83)
    at u (examples.19edb846.js:1)
    at p (examples.19edb846.js:1)
    at Object.parcelRequire.10.re-classnames/src/Cn.bs.js (examples.19edb846.js:87)

💁 Possible Solution

None.

🔦 Context

How to reproduce:

  1. Clone https://github.com/alexfedoseev/re-formality/
  2. Switch to bump-parcel branch
  3. Run yarn run build
  4. Open dist/index.html in browser (w/o server need to add ./ prefixes to assets paths)

💻 Code Sample

https://github.com/alexfedoseev/re-formality/tree/bump-parcel

🌍 Your Environment

| Software         | Version(s) |
| ---------------- | ---------- |
| Parcel           | 1.9.1
| Node             | 10.1.0
| npm/Yarn         | 1.6.0
| Operating System | macOS 10.13.5
@safareli
Copy link

safareli commented Jul 7, 2018

looks like it's same issue as #1656

@justinwoo
Copy link

Almost identical issue for me with 1.9.7

@safareli
Copy link

If you don't the issue with --no-minify than it might be issue with default ugglify options.

@alex35mil
Copy link
Author

Fixed for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants