Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is pkg.source a safe import target? #1652

Closed
alexkrolick opened this issue Jul 3, 2018 · 2 comments
Closed

Is pkg.source a safe import target? #1652

alexkrolick opened this issue Jul 3, 2018 · 2 comments
Labels
❔ Question Stale Inactive issues

Comments

@alexkrolick
Copy link

Seems like trying to use package.json's source field could be a source of issues:

let main = [pkg.source, pkg.module, browser, pkg.main].find(

  • microbundle uses source to identify the pre-Babel source code of a module, which could be a problem if the bundle config for the consumer doesn't match the source
  • Is there an RFC for using source in imports like there is for jsnext or module? Seems safer to treat as reserved for internal use of the package.
@mischnic
Copy link
Member

microbundle uses source to identify the pre-Babel source code of a module, which could be a problem if the bundle config for the consumer doesn't match the source

We should be using the actual babel config of that package in this case.

Is there an RFC for using source in imports

There is no spec for package.json that actually reflects the current usage.

@stale
Copy link

stale bot commented Jan 17, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 30 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale Inactive issues label Jan 17, 2020
@github-actions github-actions bot closed this as completed Feb 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
❔ Question Stale Inactive issues
Projects
None yet
Development

No branches or pull requests

3 participants