-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When site.webmanifest file that is not in root directory, icons paths are incorrect #3588
Comments
Still an issue |
Ran into the same problem. |
The issue is related to the wrong build method being use for the webmanifest. If you use 'parcel build' you get the un-minified manifest with path to the un-renamed image. If you use 'parcel' to build on the dev server you get the minified webmanifest with link to the renamed images on the root., I'm guessing there is a '!' missing somewhere. |
Ran into the same problem... |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. |
Still an issue. |
🐛 bug report
static/site.webmanifest
(code)/static/site.webmanifest
(code)test-webmanifest.2044b095.png
(code) — which should be relative to the webmanifest insidestatic/
dist/
foldr (dist directory)🎛 Configuration (.babelrc, package.json, cli command)
See the above repo.
🤔 Expected Behavior
I would expect the
test-webmanifest.2044b095.png
file to end up in thestatic/
directory.According to the examples (Google Developers Web App Manifest, MDN Web Manifest) for the manifest of a PWA, the "icons" file paths should include the paths to files.
Albeit, this is different from browser extensions manifests (MDN extension manifest docs)
😯 Current Behavior
I would expect the
test-webmanifest.2044b095.png
file is placed in the root of thedist/
directory.💁 Possible Solution
It seems like linked assets in a webmanifest file should be placed in the proper relative directory.
As a workaround, I just moved everything to the root directory of my static app.
🔦 Context
💻 Code Sample
See the above repo.
🌍 Your Environment
The text was updated successfully, but these errors were encountered: