Revert "use npm for auto-install by default" #2125

devongovett · 2018-10-12T15:01:11Z

Reverts #2119

Reduces amount of warnings during tests.

* handle empty config && asset files * remove bad empty asset solution

--- name: Add test to fs.readFileSync in TypeScript files --- ``` parcel-bundler version 1.9.7 ``` ## 💥 Problem Inlining file in browser mode doesn't work in TypeScript files when `fs` is imported with star import or default import. The only way to use `readFileSync` is: ```typescript import { readFileSync } from 'fs'; const raw = readFileSync(__dirname + '/raw.tsx', 'utf-8'); ``` ### Reproduction: Repo: https://github.com/hasparus/parcel-readfilesync-typescript-repro ghPages: https://hasparus.github.io/parcel-readfilesync-typescript-repro/ CodeSandbox: https://codesandbox.io/s/github/hasparus/parcel-readfilesync-typescript-repro/tree/master/ Fun Fact: All ways to import `fs` work on CodeSandbox (parcel template). ## ↪️ Pull Request Adds test to `fs.readFileSync` in TypeScript files and thus provides better workaround for #1736. ## ✔️ PR Todo - [X] Link in #1736. - [X] Post reproduction to CodeSandbox. - [ ] Document how to use `readFileSync` in TypeScript?

Was running `parcel build` and the auto installer started running, I went to disable it and found that the option was not available here

# ↪️ Pull Request Do not load existing sourcemaps if sourcemaps are disabled

--- name: 🙋 Fix HMR for Pug assets ---  ## ↪️ Pull Request  #2090 ## 💻 Examples  ## ✔️ PR Todo - [ ] Added/updated unit tests for this change - [ ] Filled out test instructions - [x] Included links to related issues/PRs

#2113)

# ↪️ Pull Request  Changed the logic to determine which package manager to use during auto-installation. The only situation Parcel should use yarn is when it satisfies - There is `yarn` command available AND - There is `yarn.lock` file AND - There is NOT `package-lock.json` Otherwise, it uses npm. Fixes #2117 ## 🚨 Test instructions  Setup a testing directory with different setups (package-lock existence, yarn.lock existence, yarn command existence). The only situation Parcel should use yarn is when - There is `yarn` command available AND - There is `yarn.lock` file AND - There is NOT `package-lock.json` ## ✔️ PR Todo ~~- [ ] Added/updated unit tests for this change~~ - [x] Filled out test instructions (In case there aren't any unit tests) - [x] Included links to related issues/PRs  ## Side note There is a situation where there are both package-lock.json and yarn.lock. Having npm as default package manager means that it should use npm in this situation. That's why there is only one situation where Parcel should use yarn.

This reverts commit a0df886.

This reverts commit 1b808ec.

…dle (#2122)" This reverts commit 75f4164.

This reverts commit b539cb6.

Hoishin · 2018-10-12T15:03:40Z

@devongovett The problem is the case of having no lock file at all. ~~Yarn enforces you to make yarn.lock even if you gitignore, first time you use yarn the file is made.~~ It is a bit harder to generate no lock file with yarn.
On the other hand, it is ~~entirely possible~~ a bit easier to have no lock file using npm, just setting lock file to off in .npmrc.

(copy of #2119 (comment))

(edit)
I think the word "default" was misunderstood. It is a default in terms of using npm when there is no yarn.lock or package-lock.json.

(edit2)
Actually you can pass --no-lock-file to yarn install too... I think it is still valid opinion since you can have no lock file as project in npm, but not in yarn. For example I couldn't find a way to add a package with yarn without making yarn.lock.

DeMoorJasper · 2018-10-12T15:07:12Z

Related issue #2117

Jasper De Moor and others added 30 commits March 27, 2018 20:16

Initial vue support (#1052)

ba93b87

Add overlay for build errors when using hmr (#1074)

32c796d

Fix methods of LazyPromise (#1059)

74438d4

Ignore require if it is defined (#975)

12b649b

Check browserslist prop in package.json for environments (#1053)

39e4f7a

add support for data attr of object element (#1069)

6e8ae0d

Add useBuiltIns babel-preset-env option (fix #843) (#878)

e26d443

Fix builtin loaders with --target=node (#981)

9d6061c

Update changelog

27e1d02

Wait for the next event loop iteration when loading WASM (#1086)

fb47244

Fix test not using the projectBasePath (#1081)

279f043

1.7.0

0140dce

Add support for scoped plugin packages (#1112) (#1117)

9792f48

Fix writing files in subfolders inside dist directory (#1097)

0e1863b

Add “private: true” to package.json files in tests. (#1142)

9038991

Reduces amount of warnings during tests.

Update addBundleLoader to accept multiple targets (#1085)

9f3f30a

Fix sourcemap reference in JS output (#1148)

28b87cf

Sourcemap sourceRoot (#1141)

3b1a585

Fix serving files with query params (#1169)

3435c4c

Give priority to styl files in StylusAsset resolver (#1090)

89952d7

Bump dependencies (#1089) (#1184)

4189563

Fix asset size always be zero when building vue project (#1151)

25a054f

Custom workerfarm, BI-Directional IPC (#1105)

69625e0

1.7.1

1bfba6e

Update changelog

bfc1d3c

Change appveyor badge to master branch (#1197)

bb7f4aa

[Fix] Prevent build from breaking when .scss file is empty (#1193)

7a2ba16

Handle empty config files (#1203)

11a7882

* handle empty config && asset files * remove bad empty asset solution

Update dependency with security vuln (#1246)

06999a0

Minor change to mkHandle in workerfarm (#1233)

0d984a5

devongovett and others added 24 commits September 25, 2018 08:49

Don’t add export proposal syntax by default

6c8c231

Fix merging parser plugins in babel 6

4023c84

1.10.0

10960f7

Fix error when node.id is undefined instead of null

a78bc95

1.10.1

56b2dad

Update changelog

9aa562b

add missing --no-autoinstall flag to build command (#2076)

c58dce8

Was running `parcel build` and the auto installer started running, I went to disable it and found that the option was not available here

Don't load existing sourcemaps if sourcemaps are disabled (#2089)

419ade9

# ↪️ Pull Request Do not load existing sourcemaps if sourcemaps are disabled

Fix safari 10 compatibility for terser (#2103)

0b13f00

Fix hoisting of optional require calls (#2078)

fa4c467

Fix hoist of modules with multiple aliases (#2077)

adf49c2

add <image> as a valid element type to bundle in <svg> tags (w/ tests) (

fae786a

#2113)

resolving .postcssrc.json as a PostCSS config (#2115)

db91bd4

Slightly improve PR templates (#2088)

0f92c83

Add loaders when bundling workers (#2092)

3b4e37e

Changelog for v1.10.2

66d9d61

1.10.2

c734423

Revert "1.10.3"

e99db25

This reverts commit a0df886.

Revert "Update changelog"

747e2ae

This reverts commit 1b808ec.

Revert "Don't dedupe assets that are depended on in more than one bun…

94bf4ae

…dle (#2122)" This reverts commit 75f4164.

Revert "use npm for auto-install by default (#2119)"

3426b77

This reverts commit b539cb6.

devongovett closed this Oct 16, 2018

devongovett force-pushed the master branch from d2dc7c9 to 75310e1 Compare October 16, 2018 03:52

DeMoorJasper deleted the revert-2119-auto-install-default branch December 15, 2019 13:47

zor-el mentioned this pull request Dec 15, 2019

Sensible Package Manager Defaults For Auto-Install #3919

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Revert "use npm for auto-install by default" #2125

Revert "use npm for auto-install by default" #2125

devongovett commented Oct 12, 2018

Hoishin commented Oct 12, 2018 •

edited

Loading

DeMoorJasper commented Oct 12, 2018

Revert "use npm for auto-install by default" #2125

Revert "use npm for auto-install by default" #2125

Conversation

devongovett commented Oct 12, 2018

Hoishin commented Oct 12, 2018 • edited Loading

DeMoorJasper commented Oct 12, 2018

Hoishin commented Oct 12, 2018 •

edited

Loading