Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hoisting of optional require calls #2078

Merged
merged 1 commit into from
Oct 6, 2018
Merged

Fix hoisting of optional require calls #2078

merged 1 commit into from
Oct 6, 2018

Conversation

fathyb
Copy link
Contributor

@fathyb fathyb commented Sep 29, 2018

name: Fix hoisting of optional require calls

↪️ Pull Request

See test case

💻 Examples

See test case

✔️ PR Todo

  • Added/updated unit tests for this change
  • Filled out test instructions
  • Included links to related issues/PRs

@devongovett devongovett merged commit fa4c467 into master Oct 6, 2018
@devongovett devongovett deleted the fix/hoist-optional-require branch October 6, 2018 14:02
devongovett pushed a commit that referenced this pull request Oct 15, 2018
@fathyb @devongovett
Fix hoisting of optional require calls (#2078)
198191a
devongovett pushed a commit that referenced this pull request Oct 15, 2018
@fathyb @devongovett
Fix hoisting of optional require calls (#2078)
cadb1d4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devongovett devongovett devongovett approved these changes

Assignees
No one assigned
Labels
🐛 Bug 🌳 Scope Hoisting
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fathyb @devongovett