New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update sourcemap to rc-1.0 #6279

Merged

devongovett merged 7 commits into v2 from update-sourcemap

May 15, 2021

Member

DeMoorJasper commented May 13, 2021

↪️ Pull Request

This PR updates all parcel packages to be compatible with the newest Rust version of the source-map library.

Made some breaking changes in the API as well, before it's too late (stable release)

✔️ PR Todo

Added/updated unit tests for this change
Filled out test instructions (In case there aren't any unit tests)
Included links to related issues/PRs


          update sourcemap to rc01

eb5883a

height bot commented May 13, 2021

Link Height tasks by mentioning a task ID in the pull request title or description, commit messages, or comments.

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

parcel-benchmark commented May 13, 2021 •

edited

Benchmark Results

Kitchen Sink 🚨

Timings

Description	Time	Difference
Cold	FAILED	-0.00ms
Cached	FAILED	-0.00ms

Cold Bundles

No bundles found, this is probably a failed build...

Cached Bundles

No bundles found, this is probably a failed build...

React HackerNews 🚨

Timings

Description	Time	Difference
Cold	FAILED	-0.00ms
Cached	FAILED	-0.00ms

Cold Bundles

No bundles found, this is probably a failed build...

Cached Bundles

No bundles found, this is probably a failed build...

AtlasKit Editor 🚨

Timings

Description	Time	Difference
Cold	FAILED	-0.00ms
Cached	FAILED	-0.00ms

Cold Bundles

No bundles found, this is probably a failed build...

Cached Bundles

No bundles found, this is probably a failed build...

Three.js 🚨

Timings

Description	Time	Difference
Cold	FAILED	-0.00ms
Cached	FAILED	-0.00ms

Cold Bundles

No bundles found, this is probably a failed build...

Cached Bundles

No bundles found, this is probably a failed build...

Click here to view a detailed benchmark overview.


          fix some sourcemap tests

3c11162

Member Author

DeMoorJasper commented May 13, 2021

checkSourceMapping is failing due to a change in the source-map library where we no longer match mappings after the requested index for findClosestMapping, this was to mimic the behaviour of source-map by Mozilla. This could easily be changed, not sure what we want here.

Member

mischnic commented May 13, 2021

You mean that findClosestMapping now returns the nearest mapping that comes before the passed position? I think that makes more sense anyway.

Member Author

DeMoorJasper commented May 13, 2021 •

edited

@mischnic Yeah exactly, that's how other libraries work so changed it. In that case I'll update the test util to work with this change

devongovett requested changes

View reviewed changes

packages/packagers/js/src/ScopeHoistingPackager.js Outdated Show resolved Hide resolved

DeMoorJasper added 2 commits

May 13, 2021 18:58


          use addSourceMap instead of addBuffer

bcf0cbc


          Merge branch 'v2' into update-sourcemap

f2c2d86

Member

devongovett commented May 14, 2021

Looks like CI is failing on addSourceMap...

DeMoorJasper added 3 commits

May 14, 2021 10:07


          Merge branch 'v2' into update-sourcemap

4393c98


          dont do addSourceMap if it's a buffer

2a97f76


          work around issues for now, gotta refactor sourcemap tests at some po…

a9bd981

…int perhaps

devongovett approved these changes

View reviewed changes

devongovett merged commit afaab71 into v2

devongovett deleted the update-sourcemap branch

May 15, 2021 03:16

lettertwo added a commit that referenced this pull request


          Merge branch 'bdo/buffer-backed-graph' into lettertwo/buffer-backed-g…

d2bc2f9

…raph

* bdo/buffer-backed-graph: (37 commits)
  Improve resolver performance (#6328)
  v2.0.0-beta.3.1
  Add it to the nightly release workflow as well
  Configure jemalloc page size for M1 (#6314)
  Update swc (#6307)
  Fix parcelDependencies
  v2.0.0-beta.3
  Update swc (#6289)
  Remove old AdjacencyList, serialize EfficientGraph in Graph, update BundleGraph to use new functions
  Babel ast location, diagnostic, and source location remapping (#6238)
  update contributing guide (#6293)
  Update sourcemap to rc-1.0 (#6279)
  Serve nearest index.html in case the applications has multiple index files (#6250)
  Allow bundling browserify bundles by replacing free requires with undefined (#6260)
  Upgrade flow to 0.151.0 (#6281)
  Use local require for `@babel/core` and `postcss` (#6264)
  Resolve helpers relative to JS transformer (#6278)
  Pure comment for $parcel$interopDefault (#6271)
  Don't transpile spread in JSX with modern targets (#6274)
  Update TS validator assertions (#6272)
  ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment