New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update swc #6289

Merged

mischnic merged 1 commit into v2 from update-swc

May 17, 2021

Member

mischnic commented May 16, 2021 •

edited

Closes #6282
Closes #6296

mischnic requested review from devongovett and DeMoorJasper

May 16, 2021 08:54

height bot commented May 16, 2021

Link Height tasks by mentioning a task ID in the pull request title or description, commit messages, or comments.

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

DeMoorJasper approved these changes

View reviewed changes

parcel-benchmark commented May 16, 2021 •

edited

Benchmark Results

Kitchen Sink 🚨

Timings

Description	Time	Difference
Cold	FAILED	-0.00ms
Cached	FAILED	-0.00ms

Cold Bundles

No bundles found, this is probably a failed build...

Cached Bundles

No bundles found, this is probably a failed build...

React HackerNews 🚨

Timings

Description	Time	Difference
Cold	FAILED	-0.00ms
Cached	FAILED	-0.00ms

Cold Bundles

No bundles found, this is probably a failed build...

Cached Bundles

No bundles found, this is probably a failed build...

AtlasKit Editor 🚨

Timings

Description	Time	Difference
Cold	FAILED	-0.00ms
Cached	FAILED	-0.00ms

Cold Bundles

No bundles found, this is probably a failed build...

Cached Bundles

No bundles found, this is probably a failed build...

Three.js 🚨

Timings

Description	Time	Difference
Cold	FAILED	-0.00ms
Cached	FAILED	-0.00ms

Cold Bundles

No bundles found, this is probably a failed build...

Cached Bundles

No bundles found, this is probably a failed build...

Click here to view a detailed benchmark overview.

danieltroger mentioned this pull request

Reproducible segfaults #6292

Closed

Member Author

mischnic commented May 16, 2021 •

edited

Tests are broken because a TS file with

console.log('Hello Parcel!')

is transformed by swc into

console.log('Hello Parcel!')
export {};

after swc-project/swc#1698.

-> swc-project/swc#1706

Contributor

danieltroger commented May 17, 2021

NOOOOOOOOOOOOO yet another day without a nightly where my private class fields don't throw errors 😟

Member Author

mischnic commented May 17, 2021 •

edited

A workaround is adding a Babel config with @parcel/babel-preset-env (so that it's not swc which transpiles it).

I'll update the failing test so that we can merge this if it's not fixed in swc today.

Contributor

danieltroger commented May 17, 2021

I'll update the failing test so that we can merge this if it's not fixed in swc today.

Thanks! But yo, adding babel-preset-env actually works!

But I just discovered #6296 so the thing I'd need to update for (having a person that doesn't have parcel installed install it and do some QA for me) doesn't work anyways lol.


          Update swc

490deb4

mischnic force-pushed the update-swc branch from 01e9022 to 490deb4 Compare

May 17, 2021 13:34

mischnic merged commit 71b3b93 into v2

mischnic deleted the update-swc branch

May 17, 2021 17:52

lettertwo added a commit that referenced this pull request


          Merge branch 'bdo/buffer-backed-graph' into lettertwo/buffer-backed-g…

d2bc2f9

…raph

* bdo/buffer-backed-graph: (37 commits)
  Improve resolver performance (#6328)
  v2.0.0-beta.3.1
  Add it to the nightly release workflow as well
  Configure jemalloc page size for M1 (#6314)
  Update swc (#6307)
  Fix parcelDependencies
  v2.0.0-beta.3
  Update swc (#6289)
  Remove old AdjacencyList, serialize EfficientGraph in Graph, update BundleGraph to use new functions
  Babel ast location, diagnostic, and source location remapping (#6238)
  update contributing guide (#6293)
  Update sourcemap to rc-1.0 (#6279)
  Serve nearest index.html in case the applications has multiple index files (#6250)
  Allow bundling browserify bundles by replacing free requires with undefined (#6260)
  Upgrade flow to 0.151.0 (#6281)
  Use local require for `@babel/core` and `postcss` (#6264)
  Resolve helpers relative to JS transformer (#6278)
  Pure comment for $parcel$interopDefault (#6271)
  Don't transpile spread in JSX with modern targets (#6274)
  Update TS validator assertions (#6272)
  ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment