Improve resolver performance #6328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
devongovett
commented
May 21, 2021
| @@ -798,18 +803,27 @@ export default class NodeResolver { | |||
| return null; | |||
| } | |||
|
|
|||
| let pkgKeys = ['source', 'alias']; | |||
| if (env.isBrowser()) pkgKeys.push('browser'); | |||
| if (pkg.source && !Array.isArray(pkg.source)) { | |||
There was a problem hiding this comment.
Making this function use static references rather than dynamic property accesses seems to improve performance quite a bit
mischnic
reviewed
May 21, 2021
| @@ -87,7 +88,7 @@ export async function loadConfig( | |||
| if (parse === false) { | |||
| config = configContent; | |||
| } else { | |||
| let parse = getParser(extname); | |||
| let parse = opts?.parser ?? getParser(extname); | |||
There was a problem hiding this comment.
That isn't part of the configCache cache key. But I also can't think of a case where you would want to parse a single file with 2 different parsers.
There was a problem hiding this comment.
Yeah, let's hope not 😉
DeMoorJasper
approved these changes
May 21, 2021
Benchmark ResultsKitchen Sink ✅
Timings
Cold Bundles
Cached Bundles
React HackerNews ✅
Timings
Cold BundlesNo bundle changes detected. Cached Bundles
AtlasKit Editor ✅
Timings
Cold Bundles
Cached Bundles
Three.js ✅
Timings
Cold BundlesNo bundle changes detected. Cached Bundles
|
lettertwo
added a commit
that referenced
this pull request
Jun 4, 2021
…raph * bdo/buffer-backed-graph: (37 commits) Improve resolver performance (#6328) v2.0.0-beta.3.1 Add it to the nightly release workflow as well Configure jemalloc page size for M1 (#6314) Update swc (#6307) Fix parcelDependencies v2.0.0-beta.3 Update swc (#6289) Remove old AdjacencyList, serialize EfficientGraph in Graph, update BundleGraph to use new functions Babel ast location, diagnostic, and source location remapping (#6238) update contributing guide (#6293) Update sourcemap to rc-1.0 (#6279) Serve nearest index.html in case the applications has multiple index files (#6250) Allow bundling browserify bundles by replacing free requires with undefined (#6260) Upgrade flow to 0.151.0 (#6281) Use local require for `@babel/core` and `postcss` (#6264) Resolve helpers relative to JS transformer (#6278) Pure comment for $parcel$interopDefault (#6271) Don't transpile spread in JSX with modern targets (#6274) Update TS validator assertions (#6272) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Utilizes the config loading mechanism used by other stuff for loading package.json files in the resolver, which has a per-build cache. Improves perf on the esbuild benchmark by ~8% for me.