Add support for injecting manifest into service workers #6798

devongovett · 2021-08-29T03:28:52Z

This adds a @parcel/runtime-service-worker plugin, which can be used to inject a manifest of bundles along with a version hash into a service worker. There is also a "browser" target for this plugin that you can import in a service worker to access the manifest/version.

For example (code based on https://bundlers.tooling.report/non-js-resources/service-worker/):

import {manifest, version} from '@parcel/runtime-service-worker';

async function install() {
  const cache = await caches.open(version);
  await cache.addAll(manifest);
}
addEventListener('install', e => e.waitUntil(install()));

async function activate() {
  const keys = await caches.keys();
  await Promise.all(keys.map(key => key !== version && caches.delete(key)));
}
addEventListener('activate', e => e.waitUntil(activate()));

height · 2021-08-29T03:28:54Z

Link Height tasks by mentioning a task ID in the pull request title or description, commit messages, or comments.

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

parcel-benchmark · 2021-08-29T04:06:50Z

Benchmark Results

Kitchen Sink ✅

Timings

Description	Time	Difference
Cold	1.57s	+6.00ms
Cached	277.00ms	+17.00ms ⚠️

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

React HackerNews ✅

Timings

Description	Time	Difference
Cold	8.47s	-67.00ms
Cached	418.00ms	+6.00ms

Cold Bundles

Bundle	Size	Difference	Time	Difference
dist/logo.c5bb83f1.png	246.00b	+0.00b	4.54s	+534.00ms ⚠️

Cached Bundles

No bundle changes detected.

AtlasKit Editor ✅

Timings

Description	Time	Difference
Cold	56.91s	-164.00ms
Cached	1.60s	+86.00ms ⚠️

Cold Bundles

Bundle	Size	Difference	Time	Difference
dist/index.334769ba.js	1.77mb	-8.00b 🚀	16.41s	+4.00ms
dist/index.2017f979.js	694.59kb	+19.00b ⚠️	43.89s	+47.00ms

Cached Bundles

Bundle	Size	Difference	Time	Difference
dist/index.ed2b7d05.js	1.77mb	-6.00b 🚀	16.91s	+400.00ms
dist/index.fefdc2ee.js	694.58kb	+4.00b ⚠️	45.28s	+1.50s
dist/Modal.b23a7ff6.js	45.30kb	+15.00b ⚠️	44.77s	+1.44s

Three.js ✅

Timings

Description	Time	Difference
Cold	6.15s	+51.00ms
Cached	346.00ms	+1.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

Click here to view a detailed benchmark overview.

packages/runtimes/service-worker/package.json

packages/core/core/src/requests/EntryRequest.js

mischnic · 2021-08-30T09:43:13Z

packages/runtimes/service-worker/src/ServiceWorkerRuntime.js

+      manifest.push(urlJoin(b.target.publicUrl, b.name));
+    });
+
+    let code = `import {_register} from '@parcel/service-worker';


So this imports @parcel/service-worker relative to the runtime? It should rather be resolved from the user's package. Yarn 2 would still break

…rker-manifest

* v2: (69 commits) Use yarnpkg registry for all the things (#6908) Fix issue about loading configs from tsconfig.json (#6881) Add `@section` to Compressor type (#6885) Parcel API improvements (#6866) Use stream-browserify for polyfilling instead (#6863) Add support for compressor plugins (#6776) Support for inline style attributes and inline scripts in SVG (#6797) Bump less (#6852) Make sure (non-React) SVGs are in separate bundles (#6757) Add support for injecting manifest into service workers (#6798) Fix 'does not export default' error with scope hoisting and url/worklet pipeline (#6803) Remaining cargo clippy fixes (#6829) Lazily install sharp only when needed (#6816) More cargo clippy suggestions (#6811) Don't emit runtime manifest for inline child bundles (#6807) Apply suggestions from rust-clippy (#6256) Fix add directoryExists function to matchFiles call. (#6784) Upgrade to Flow 158 (#6763) Revert "added cio headers (#6404)" (#6789) Process CSS in SVGs (#6743) ...

* v2: (38 commits) Use yarnpkg registry for all the things (#6908) Fix issue about loading configs from tsconfig.json (#6881) Add `@section` to Compressor type (#6885) Parcel API improvements (#6866) Use stream-browserify for polyfilling instead (#6863) Add support for compressor plugins (#6776) Support for inline style attributes and inline scripts in SVG (#6797) Bump less (#6852) Make sure (non-React) SVGs are in separate bundles (#6757) Add support for injecting manifest into service workers (#6798) Fix 'does not export default' error with scope hoisting and url/worklet pipeline (#6803) Remaining cargo clippy fixes (#6829) Lazily install sharp only when needed (#6816) More cargo clippy suggestions (#6811) Don't emit runtime manifest for inline child bundles (#6807) Apply suggestions from rust-clippy (#6256) Fix add directoryExists function to matchFiles call. (#6784) Upgrade to Flow 158 (#6763) Revert "added cio headers (#6404)" (#6789) Process CSS in SVGs (#6743) ...

* bdo/number-edgetypes: (70 commits) Use yarnpkg registry for all the things (#6908) Fix issue about loading configs from tsconfig.json (#6881) Add `@section` to Compressor type (#6885) Parcel API improvements (#6866) Use stream-browserify for polyfilling instead (#6863) Add support for compressor plugins (#6776) Support for inline style attributes and inline scripts in SVG (#6797) Bump less (#6852) Make sure (non-React) SVGs are in separate bundles (#6757) Add support for injecting manifest into service workers (#6798) Fix 'does not export default' error with scope hoisting and url/worklet pipeline (#6803) Remaining cargo clippy fixes (#6829) Lazily install sharp only when needed (#6816) More cargo clippy suggestions (#6811) Don't emit runtime manifest for inline child bundles (#6807) Apply suggestions from rust-clippy (#6256) Fix add directoryExists function to matchFiles call. (#6784) Upgrade to Flow 158 (#6763) Revert "added cio headers (#6404)" (#6789) Process CSS in SVGs (#6743) ...

* v2: (38 commits) Use yarnpkg registry for all the things (#6908) Fix issue about loading configs from tsconfig.json (#6881) Add `@section` to Compressor type (#6885) Parcel API improvements (#6866) Use stream-browserify for polyfilling instead (#6863) Add support for compressor plugins (#6776) Support for inline style attributes and inline scripts in SVG (#6797) Bump less (#6852) Make sure (non-React) SVGs are in separate bundles (#6757) Add support for injecting manifest into service workers (#6798) Fix 'does not export default' error with scope hoisting and url/worklet pipeline (#6803) Remaining cargo clippy fixes (#6829) Lazily install sharp only when needed (#6816) More cargo clippy suggestions (#6811) Don't emit runtime manifest for inline child bundles (#6807) Apply suggestions from rust-clippy (#6256) Fix add directoryExists function to matchFiles call. (#6784) Upgrade to Flow 158 (#6763) Revert "added cio headers (#6404)" (#6789) Process CSS in SVGs (#6743) ...

* bdo/number-edgetypes: (70 commits) Use yarnpkg registry for all the things (#6908) Fix issue about loading configs from tsconfig.json (#6881) Add `@section` to Compressor type (#6885) Parcel API improvements (#6866) Use stream-browserify for polyfilling instead (#6863) Add support for compressor plugins (#6776) Support for inline style attributes and inline scripts in SVG (#6797) Bump less (#6852) Make sure (non-React) SVGs are in separate bundles (#6757) Add support for injecting manifest into service workers (#6798) Fix 'does not export default' error with scope hoisting and url/worklet pipeline (#6803) Remaining cargo clippy fixes (#6829) Lazily install sharp only when needed (#6816) More cargo clippy suggestions (#6811) Don't emit runtime manifest for inline child bundles (#6807) Apply suggestions from rust-clippy (#6256) Fix add directoryExists function to matchFiles call. (#6784) Upgrade to Flow 158 (#6763) Revert "added cio headers (#6404)" (#6789) Process CSS in SVGs (#6743) ...

* v2: (42 commits) Remove dead link to docs in diagnostic (#6913) Fix engines.parcel in SVG packager (#6911) Use imported Readable flow type instead of global (#6910) Use non-deprecated SVGO options in HTMLNanoOptimizer (#6785) Use yarnpkg registry for all the things (#6908) Fix issue about loading configs from tsconfig.json (#6881) Add `@section` to Compressor type (#6885) Parcel API improvements (#6866) Use stream-browserify for polyfilling instead (#6863) Add support for compressor plugins (#6776) Support for inline style attributes and inline scripts in SVG (#6797) Bump less (#6852) Make sure (non-React) SVGs are in separate bundles (#6757) Add support for injecting manifest into service workers (#6798) Fix 'does not export default' error with scope hoisting and url/worklet pipeline (#6803) Remaining cargo clippy fixes (#6829) Lazily install sharp only when needed (#6816) More cargo clippy suggestions (#6811) Don't emit runtime manifest for inline child bundles (#6807) Apply suggestions from rust-clippy (#6256) ...

* bdo/number-edgetypes: (74 commits) Remove dead link to docs in diagnostic (#6913) Fix engines.parcel in SVG packager (#6911) Use imported Readable flow type instead of global (#6910) Use non-deprecated SVGO options in HTMLNanoOptimizer (#6785) Use yarnpkg registry for all the things (#6908) Fix issue about loading configs from tsconfig.json (#6881) Add `@section` to Compressor type (#6885) Parcel API improvements (#6866) Use stream-browserify for polyfilling instead (#6863) Add support for compressor plugins (#6776) Support for inline style attributes and inline scripts in SVG (#6797) Bump less (#6852) Make sure (non-React) SVGs are in separate bundles (#6757) Add support for injecting manifest into service workers (#6798) Fix 'does not export default' error with scope hoisting and url/worklet pipeline (#6803) Remaining cargo clippy fixes (#6829) Lazily install sharp only when needed (#6816) More cargo clippy suggestions (#6811) Don't emit runtime manifest for inline child bundles (#6807) Apply suggestions from rust-clippy (#6256) ...

devongovett added 3 commits August 28, 2021 20:21

Add support for injecting manifest into service workers

f390719

Don't wrap assets referenced by URL dependencies

1dd4f31

Add missing dep

e6af466

devongovett added 2 commits August 28, 2021 21:27

Fix flow

683b996

Add TS types

c930b5d

devongovett mentioned this pull request Aug 29, 2021

Add docs for service worker manifest parcel-bundler/website#913

Merged

mischnic reviewed Aug 29, 2021

View reviewed changes

packages/runtimes/service-worker/package.json Outdated Show resolved Hide resolved

devongovett added 2 commits August 29, 2021 15:00

Move service worker client to its own package

052ba27

lint

dccda18

mischnic reviewed Aug 30, 2021

View reviewed changes

packages/core/core/src/requests/EntryRequest.js Outdated Show resolved Hide resolved

mischnic reviewed Aug 30, 2021

View reviewed changes

devongovett added 3 commits August 30, 2021 22:18

Merge branch 'v2' of github.com:parcel-bundler/parcel into service-wo…

81623f1

…rker-manifest

Resolve from the correct location

4daa7de

Revert now unused changes

0bbe7d4

mischnic approved these changes Sep 1, 2021

View reviewed changes

devongovett merged commit de2ca3d into v2 Sep 1, 2021

devongovett deleted the service-worker-manifest branch September 1, 2021 16:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for injecting manifest into service workers #6798

Add support for injecting manifest into service workers #6798

devongovett commented Aug 29, 2021

height bot commented Aug 29, 2021

parcel-benchmark commented Aug 29, 2021 •

edited

Timings

Cold Bundles

Cached Bundles

Timings

Cold Bundles

Cached Bundles

Timings

Cold Bundles

Cached Bundles

Timings

Cold Bundles

Cached Bundles

mischnic Aug 30, 2021

Add support for injecting manifest into service workers #6798

Add support for injecting manifest into service workers #6798

Conversation

devongovett commented Aug 29, 2021

height bot commented Aug 29, 2021

parcel-benchmark commented Aug 29, 2021 • edited

Benchmark Results

Timings

Cold Bundles

Cached Bundles

Timings

Cold Bundles

Cached Bundles

Timings

Cold Bundles

Cached Bundles

Timings

Cold Bundles

Cached Bundles

mischnic Aug 30, 2021

Choose a reason for hiding this comment

parcel-benchmark commented Aug 29, 2021 •

edited