Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More cargo clippy suggestions #6811

Merged
merged 6 commits into from Aug 30, 2021
Merged

More cargo clippy suggestions #6811

merged 6 commits into from Aug 30, 2021

Conversation

mischnic
Copy link
Member

Nothing big, see individual commits. Hiding whitespace changes can help

@height
Copy link

height bot commented Aug 29, 2021

Link Height tasks by mentioning a task ID in the pull request title or description, commit messages, or comments.

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@parcel-benchmark
Copy link

parcel-benchmark commented Aug 29, 2021

Benchmark Results

Kitchen Sink ✅

Timings

Description Time Difference
Cold 2.26s -76.00ms
Cached 345.00ms +3.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

React HackerNews ✅

Timings

Description Time Difference
Cold 11.38s +28.00ms
Cached 534.00ms +42.00ms ⚠️

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

AtlasKit Editor ✅

Timings

Description Time Difference
Cold 1.24m -1.13s
Cached 1.78s -121.00ms 🚀

Cold Bundles

Bundle Size Difference Time Difference
dist/index.d97083b0.js 694.58kb +15.00b ⚠️ 57.30s -677.00ms

Cached Bundles

Bundle Size Difference Time Difference
dist/index.6b09c389.js 1.77mb -4.00b 🚀 21.06s -1.40s 🚀
dist/editorView.1de3e689.js 594.90kb +0.00b 55.31s +11.81s ⚠️
dist/popup.d754c7eb.js 209.65kb +0.00b 55.31s +11.81s ⚠️
dist/EmojiPickerComponent.8b8a0fcb.js 146.66kb +0.00b 34.37s +10.21s ⚠️
dist/Toolbar.303d28b1.js 107.22kb +0.00b 55.31s +11.81s ⚠️
dist/card.c48c93b8.js 62.65kb +0.00b 56.03s +12.53s ⚠️
dist/Modal.5830bebd.js 45.31kb +0.00b 55.32s +11.82s ⚠️
dist/component.f1066e79.js 37.33kb +0.00b 21.06s -1.40s 🚀
dist/esm.154a95d4.js 33.13kb +0.00b 34.37s +10.21s ⚠️
dist/component.fbe1326b.js 24.93kb +0.00b 21.06s -1.40s 🚀
dist/DatePicker.97503a5c.js 22.96kb +0.00b 34.37s +10.21s ⚠️
dist/js.0f0bb621.js 17.24kb +0.00b 55.31s +11.81s ⚠️
dist/ui.e33b4521.js 14.93kb +0.00b 55.32s +11.82s ⚠️
dist/smartMediaEditor.a190bd1b.js 13.24kb +0.00b 55.31s +11.81s ⚠️
dist/dropzone.0d183115.js 12.13kb +0.00b 55.31s +11.81s ⚠️
dist/component.2de9ac3a.js 6.81kb +0.00b 20.83s -1.41s 🚀
dist/card.45f850d6.js 5.75kb +0.00b 56.03s +12.53s ⚠️
dist/EmojiPickerComponent.55e0a64c.js 3.71kb +0.00b 55.32s +11.81s ⚠️
dist/png-chunks-extract.94b5b9fc.js 3.56kb +0.00b 55.31s +11.81s ⚠️
dist/dropzone.cf53fd41.js 3.28kb +0.00b 55.31s +11.81s ⚠️
dist/Modal.7f4c60b3.js 3.13kb +0.00b 56.03s +12.53s ⚠️
dist/clipboard.41697175.js 2.92kb +0.00b 55.31s +11.81s ⚠️
dist/16.7b42ca8a.js 2.33kb +0.00b 21.06s -1.40s 🚀
dist/ResourcedEmojiComponent.78f6ddfc.js 2.10kb +0.00b 55.32s +11.82s ⚠️
dist/date.c0482a02.js 1.85kb +0.00b 21.06s -1.40s 🚀
dist/images.c21e6480.js 1.79kb +0.00b 22.65s -1.51s 🚀
dist/feedback.e18b45f0.js 1.75kb +0.00b 34.37s +10.21s ⚠️
dist/16.f3960d82.js 1.72kb +0.00b 20.83s -1.40s 🚀
dist/browser.17513657.js 1.68kb +0.00b 55.31s +11.81s ⚠️
dist/16.3aec39cf.js 1.66kb +0.00b 20.83s -1.41s 🚀
dist/workerHasher.567cfc57.js 1.62kb +0.00b 34.37s +10.21s ⚠️
dist/list-number.e0420e0c.js 1.58kb +0.00b 22.65s -1.51s 🚀
dist/status.f223f976.js 1.58kb +0.00b 22.65s -1.51s 🚀
dist/code.cd95a955.js 1.50kb +0.00b 21.06s -1.40s 🚀
dist/heading6.b3b946d1.js 1.49kb +0.00b 34.37s +10.21s ⚠️
dist/heading3.33ac6e42.js 1.48kb +0.00b 22.65s -1.51s 🚀
dist/link.7487dc5e.js 1.42kb +0.00b 22.65s -1.51s 🚀
dist/16.332fbe28.js 1.37kb +0.00b 20.83s -1.40s 🚀
dist/heading5.e617db66.js 1.37kb +0.00b 34.37s +10.21s ⚠️
dist/emoji.03d3d99b.js 1.34kb +0.00b 22.65s -1.51s 🚀
dist/16.79a0250b.js 1.33kb +0.00b 20.83s -1.41s 🚀
dist/16.a877725f.js 1.33kb +0.00b 20.83s -1.41s 🚀
dist/16.0eecfc6b.js 1.30kb +0.00b 20.83s -1.40s 🚀
dist/heading2.d374048d.js 1.30kb +0.00b 22.65s -1.51s 🚀
dist/16.01994bf0.js 1.30kb +0.00b 20.83s -1.41s 🚀
dist/expand.1f17de7f.js 1.27kb +0.00b 34.37s +10.21s ⚠️
dist/16.00ba62db.js 1.27kb +0.00b 20.83s -1.40s 🚀
dist/heading4.62b9719b.js 1.25kb +0.00b 22.65s -1.51s 🚀
dist/16.8e758d30.js 1.22kb +0.00b 20.83s -1.40s 🚀
dist/16.0555a5c0.js 1.19kb +0.00b 20.83s -1.40s 🚀
dist/16.b114a692.js 1.18kb +0.00b 20.83s -1.40s 🚀
dist/mention.37efe6c4.js 1.18kb +0.00b 22.65s -1.51s 🚀
dist/16.e21a2218.js 1.18kb +0.00b 20.83s -1.40s 🚀
dist/layout.01a386bd.js 1.16kb +0.00b 22.65s -1.51s 🚀
dist/heading1.a1828016.js 1.15kb +0.00b 22.65s -1.51s 🚀
dist/divider.601227e8.js 1.14kb +0.00b 22.65s -1.51s 🚀
dist/quote.bb9e77b1.js 1.14kb +0.00b 22.65s -1.51s 🚀
dist/16.922eddd1.js 1.13kb +0.00b 20.83s -1.40s 🚀
dist/16.e92739d9.js 1.13kb +0.00b 20.83s -1.40s 🚀
dist/16.92a42544.js 1.12kb +0.00b 20.83s -1.40s 🚀
dist/16.e5c3bc4c.js 1.12kb +0.00b 20.83s -1.40s 🚀
dist/16.0358f7c7.js 1.12kb +0.00b 20.83s -1.40s 🚀
dist/action.9e337641.js 1.12kb +0.00b 21.06s -1.40s 🚀
dist/16.455c97fa.js 1.12kb +0.00b 20.83s -1.41s 🚀
dist/component.edb11b95.js 1.11kb +0.00b 21.06s -1.40s 🚀
dist/media-card-analytics-error-boundary.75fac461.js 1.10kb +0.00b 55.31s +11.81s ⚠️
dist/decision.9b91a34d.js 1.10kb +0.00b 22.65s -1.51s 🚀
dist/panel-warning.2ec3e2eb.js 1.10kb +0.00b 22.65s -1.51s 🚀
dist/16.b221eda2.js 1.08kb +0.00b 20.83s -1.40s 🚀
dist/list.13abafe4.js 1.07kb +0.00b 22.65s -1.51s 🚀
dist/16.cc9a820b.js 1.04kb +0.00b 20.83s -1.40s 🚀
dist/panel-error.9e60042f.js 1024.00b +0.00b 22.65s -1.51s 🚀
dist/panel.d9a0dff6.js 1015.00b +0.00b 22.65s -1.51s 🚀
dist/table.10221eb5.js 1007.00b +0.00b 22.65s -1.51s 🚀
dist/panel-success.6b7c55df.js 963.00b +0.00b 22.65s -1.51s 🚀
dist/panel-note.1f570859.js 959.00b +0.00b 22.65s -1.51s 🚀
dist/media-picker-analytics-error-boundary.1602c912.js 949.00b +0.00b 55.31s +11.81s ⚠️
dist/media-card-analytics-error-boundary.b1a780f3.js 945.00b +0.00b 56.03s +12.53s ⚠️
dist/simpleHasher.2a6e12b6.js 626.00b +0.00b 55.32s +11.81s ⚠️

Three.js ✅

Timings

Description Time Difference
Cold 7.91s +104.00ms
Cached 435.00ms +4.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

Click here to view a detailed benchmark overview.

@mischnic mischnic merged commit 6c62ec4 into v2 Aug 30, 2021
@mischnic mischnic deleted the cargo-clippy-2 branch August 30, 2021 19:55
lettertwo added a commit that referenced this pull request Sep 10, 2021
* v2: (69 commits)
  Use yarnpkg registry for all the things (#6908)
  Fix issue about loading configs from tsconfig.json (#6881)
  Add `@section` to Compressor type (#6885)
  Parcel API improvements (#6866)
  Use stream-browserify for polyfilling instead (#6863)
  Add support for compressor plugins (#6776)
  Support for inline style attributes and inline scripts in SVG (#6797)
  Bump less (#6852)
  Make sure (non-React) SVGs are in separate bundles (#6757)
  Add support for injecting manifest into service workers (#6798)
  Fix 'does not export default' error with scope hoisting and url/worklet pipeline (#6803)
  Remaining cargo clippy fixes (#6829)
  Lazily install sharp only when needed (#6816)
  More cargo clippy suggestions (#6811)
  Don't emit runtime manifest for inline child bundles (#6807)
  Apply suggestions from rust-clippy (#6256)
  Fix add directoryExists function to matchFiles call. (#6784)
  Upgrade to Flow 158 (#6763)
  Revert "added cio headers (#6404)" (#6789)
  Process CSS in SVGs (#6743)
  ...
lettertwo added a commit that referenced this pull request Sep 10, 2021
* v2: (38 commits)
  Use yarnpkg registry for all the things (#6908)
  Fix issue about loading configs from tsconfig.json (#6881)
  Add `@section` to Compressor type (#6885)
  Parcel API improvements (#6866)
  Use stream-browserify for polyfilling instead (#6863)
  Add support for compressor plugins (#6776)
  Support for inline style attributes and inline scripts in SVG (#6797)
  Bump less (#6852)
  Make sure (non-React) SVGs are in separate bundles (#6757)
  Add support for injecting manifest into service workers (#6798)
  Fix 'does not export default' error with scope hoisting and url/worklet pipeline (#6803)
  Remaining cargo clippy fixes (#6829)
  Lazily install sharp only when needed (#6816)
  More cargo clippy suggestions (#6811)
  Don't emit runtime manifest for inline child bundles (#6807)
  Apply suggestions from rust-clippy (#6256)
  Fix add directoryExists function to matchFiles call. (#6784)
  Upgrade to Flow 158 (#6763)
  Revert "added cio headers (#6404)" (#6789)
  Process CSS in SVGs (#6743)
  ...
lettertwo added a commit that referenced this pull request Sep 11, 2021
* bdo/number-edgetypes: (70 commits)
  Use yarnpkg registry for all the things (#6908)
  Fix issue about loading configs from tsconfig.json (#6881)
  Add `@section` to Compressor type (#6885)
  Parcel API improvements (#6866)
  Use stream-browserify for polyfilling instead (#6863)
  Add support for compressor plugins (#6776)
  Support for inline style attributes and inline scripts in SVG (#6797)
  Bump less (#6852)
  Make sure (non-React) SVGs are in separate bundles (#6757)
  Add support for injecting manifest into service workers (#6798)
  Fix 'does not export default' error with scope hoisting and url/worklet pipeline (#6803)
  Remaining cargo clippy fixes (#6829)
  Lazily install sharp only when needed (#6816)
  More cargo clippy suggestions (#6811)
  Don't emit runtime manifest for inline child bundles (#6807)
  Apply suggestions from rust-clippy (#6256)
  Fix add directoryExists function to matchFiles call. (#6784)
  Upgrade to Flow 158 (#6763)
  Revert "added cio headers (#6404)" (#6789)
  Process CSS in SVGs (#6743)
  ...
lettertwo added a commit that referenced this pull request Sep 13, 2021
* v2: (38 commits)
  Use yarnpkg registry for all the things (#6908)
  Fix issue about loading configs from tsconfig.json (#6881)
  Add `@section` to Compressor type (#6885)
  Parcel API improvements (#6866)
  Use stream-browserify for polyfilling instead (#6863)
  Add support for compressor plugins (#6776)
  Support for inline style attributes and inline scripts in SVG (#6797)
  Bump less (#6852)
  Make sure (non-React) SVGs are in separate bundles (#6757)
  Add support for injecting manifest into service workers (#6798)
  Fix 'does not export default' error with scope hoisting and url/worklet pipeline (#6803)
  Remaining cargo clippy fixes (#6829)
  Lazily install sharp only when needed (#6816)
  More cargo clippy suggestions (#6811)
  Don't emit runtime manifest for inline child bundles (#6807)
  Apply suggestions from rust-clippy (#6256)
  Fix add directoryExists function to matchFiles call. (#6784)
  Upgrade to Flow 158 (#6763)
  Revert "added cio headers (#6404)" (#6789)
  Process CSS in SVGs (#6743)
  ...
lettertwo added a commit that referenced this pull request Sep 13, 2021
* bdo/number-edgetypes: (70 commits)
  Use yarnpkg registry for all the things (#6908)
  Fix issue about loading configs from tsconfig.json (#6881)
  Add `@section` to Compressor type (#6885)
  Parcel API improvements (#6866)
  Use stream-browserify for polyfilling instead (#6863)
  Add support for compressor plugins (#6776)
  Support for inline style attributes and inline scripts in SVG (#6797)
  Bump less (#6852)
  Make sure (non-React) SVGs are in separate bundles (#6757)
  Add support for injecting manifest into service workers (#6798)
  Fix 'does not export default' error with scope hoisting and url/worklet pipeline (#6803)
  Remaining cargo clippy fixes (#6829)
  Lazily install sharp only when needed (#6816)
  More cargo clippy suggestions (#6811)
  Don't emit runtime manifest for inline child bundles (#6807)
  Apply suggestions from rust-clippy (#6256)
  Fix add directoryExists function to matchFiles call. (#6784)
  Upgrade to Flow 158 (#6763)
  Revert "added cio headers (#6404)" (#6789)
  Process CSS in SVGs (#6743)
  ...
lettertwo added a commit that referenced this pull request Sep 13, 2021
* v2: (42 commits)
  Remove dead link to docs in diagnostic (#6913)
  Fix engines.parcel in SVG packager (#6911)
  Use imported Readable flow type instead of global (#6910)
  Use non-deprecated SVGO options in HTMLNanoOptimizer (#6785)
  Use yarnpkg registry for all the things (#6908)
  Fix issue about loading configs from tsconfig.json (#6881)
  Add `@section` to Compressor type (#6885)
  Parcel API improvements (#6866)
  Use stream-browserify for polyfilling instead (#6863)
  Add support for compressor plugins (#6776)
  Support for inline style attributes and inline scripts in SVG (#6797)
  Bump less (#6852)
  Make sure (non-React) SVGs are in separate bundles (#6757)
  Add support for injecting manifest into service workers (#6798)
  Fix 'does not export default' error with scope hoisting and url/worklet pipeline (#6803)
  Remaining cargo clippy fixes (#6829)
  Lazily install sharp only when needed (#6816)
  More cargo clippy suggestions (#6811)
  Don't emit runtime manifest for inline child bundles (#6807)
  Apply suggestions from rust-clippy (#6256)
  ...
lettertwo added a commit that referenced this pull request Sep 13, 2021
* v2: (42 commits)
  Remove dead link to docs in diagnostic (#6913)
  Fix engines.parcel in SVG packager (#6911)
  Use imported Readable flow type instead of global (#6910)
  Use non-deprecated SVGO options in HTMLNanoOptimizer (#6785)
  Use yarnpkg registry for all the things (#6908)
  Fix issue about loading configs from tsconfig.json (#6881)
  Add `@section` to Compressor type (#6885)
  Parcel API improvements (#6866)
  Use stream-browserify for polyfilling instead (#6863)
  Add support for compressor plugins (#6776)
  Support for inline style attributes and inline scripts in SVG (#6797)
  Bump less (#6852)
  Make sure (non-React) SVGs are in separate bundles (#6757)
  Add support for injecting manifest into service workers (#6798)
  Fix 'does not export default' error with scope hoisting and url/worklet pipeline (#6803)
  Remaining cargo clippy fixes (#6829)
  Lazily install sharp only when needed (#6816)
  More cargo clippy suggestions (#6811)
  Don't emit runtime manifest for inline child bundles (#6807)
  Apply suggestions from rust-clippy (#6256)
  ...
lettertwo added a commit that referenced this pull request Sep 13, 2021
* bdo/number-edgetypes: (74 commits)
  Remove dead link to docs in diagnostic (#6913)
  Fix engines.parcel in SVG packager (#6911)
  Use imported Readable flow type instead of global (#6910)
  Use non-deprecated SVGO options in HTMLNanoOptimizer (#6785)
  Use yarnpkg registry for all the things (#6908)
  Fix issue about loading configs from tsconfig.json (#6881)
  Add `@section` to Compressor type (#6885)
  Parcel API improvements (#6866)
  Use stream-browserify for polyfilling instead (#6863)
  Add support for compressor plugins (#6776)
  Support for inline style attributes and inline scripts in SVG (#6797)
  Bump less (#6852)
  Make sure (non-React) SVGs are in separate bundles (#6757)
  Add support for injecting manifest into service workers (#6798)
  Fix 'does not export default' error with scope hoisting and url/worklet pipeline (#6803)
  Remaining cargo clippy fixes (#6829)
  Lazily install sharp only when needed (#6816)
  More cargo clippy suggestions (#6811)
  Don't emit runtime manifest for inline child bundles (#6807)
  Apply suggestions from rust-clippy (#6256)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants