Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use yarnpkg registry for all the things #6908

Merged
merged 1 commit into from Sep 10, 2021
Merged

Use yarnpkg registry for all the things #6908

merged 1 commit into from Sep 10, 2021

Conversation

lettertwo
Copy link
Member

↪️ Pull Request

A handful of (mostly if not all dev) dependencies are coming from a different registry than everything else. I think this was probably an oversight! This PR just updates the registry resolutions to point at the same yarn registry that everything else comes from.

@height
Copy link

height bot commented Sep 10, 2021

Link Height tasks by mentioning a task ID in the pull request title or description, commit messages, or comments.

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@parcel-benchmark
Copy link

Benchmark Results

Kitchen Sink ✅

Timings

Description Time Difference
Cold 2.15s +121.00ms ⚠️
Cached 337.00ms +19.00ms ⚠️

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

React HackerNews ✅

Timings

Description Time Difference
Cold 10.40s -340.00ms
Cached 492.00ms +34.00ms ⚠️

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

AtlasKit Editor ✅

Timings

Description Time Difference
Cold 1.15m -156.00ms
Cached 1.78s +116.00ms ⚠️

Cold Bundles

Bundle Size Difference Time Difference
dist/index.5d24e20d.js 1.78mb -6.00b 🚀 20.14s +215.00ms

Cached Bundles

Bundle Size Difference Time Difference
dist/index.fa49e8c1.js 1.78mb +1.00b ⚠️ 20.09s +24.00ms
dist/index.fae1d77b.js 694.72kb -15.00b 🚀 53.73s +1.10s
dist/editorView.9867c609.js 594.92kb +0.00b 53.67s +14.01s ⚠️
dist/popup.9bc4d2a4.js 209.67kb +0.00b 53.67s +14.02s ⚠️
dist/EmojiPickerComponent.85e68381.js 146.67kb +0.00b 21.78s -11.06s 🚀
dist/Toolbar.ebdcb2c0.js 107.23kb +0.00b 53.67s +14.01s ⚠️
dist/Modal.4b3098b4.js 45.33kb +0.00b 53.67s +14.02s ⚠️
dist/esm.c4caf633.js 33.15kb +0.00b 21.78s -11.06s 🚀
dist/DatePicker.66e8ebcb.js 22.98kb +0.00b 21.78s -11.06s 🚀
dist/ui.d0cafbb7.js 14.94kb +0.00b 53.67s +14.02s ⚠️
dist/smartMediaEditor.52e06be4.js 13.25kb +0.00b 53.67s +14.01s ⚠️
dist/dropzone.0d183115.js 12.15kb +0.00b 53.67s +14.01s ⚠️
dist/EmojiPickerComponent.55e0a64c.js 3.73kb +0.00b 53.67s +14.02s ⚠️
dist/dropzone.cf53fd41.js 3.29kb +0.00b 53.67s +14.02s ⚠️
dist/clipboard.969d5ad7.js 2.93kb +0.00b 53.68s +14.01s ⚠️
dist/ResourcedEmojiComponent.78f6ddfc.js 2.12kb +0.00b 53.67s +14.02s ⚠️
dist/feedback.e18b45f0.js 1.77kb +0.00b 21.78s -11.06s 🚀
dist/browser.17513657.js 1.69kb +0.00b 53.68s +14.01s ⚠️
dist/workerHasher.567cfc57.js 1.63kb +0.00b 21.78s -11.06s 🚀
dist/heading6.b3b946d1.js 1.51kb +0.00b 21.78s -11.06s 🚀
dist/heading5.e617db66.js 1.38kb +0.00b 21.78s -11.06s 🚀
dist/expand.1f17de7f.js 1.29kb +0.00b 21.78s -11.06s 🚀
dist/media-card-analytics-error-boundary.75fac461.js 1.12kb +0.00b 53.67s +14.02s ⚠️
dist/media-picker-analytics-error-boundary.1602c912.js 966.00b +0.00b 53.67s +14.02s ⚠️
dist/simpleHasher.2a6e12b6.js 643.00b +0.00b 53.67s +14.02s ⚠️

Three.js ✅

Timings

Description Time Difference
Cold 7.32s +2.00ms
Cached 423.00ms +21.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

Click here to view a detailed benchmark overview.

@mischnic mischnic merged commit 9aa20cf into v2 Sep 10, 2021
@mischnic mischnic deleted the lettertwo/yarn-lock-cleanup branch September 10, 2021 17:35
lettertwo added a commit that referenced this pull request Sep 10, 2021
@lettertwo
Merge branch 'v2' into lettertwo/buffer-backed-graph
01ae61b 
* v2: (69 commits)
  Use yarnpkg registry for all the things (#6908)
  Fix issue about loading configs from tsconfig.json (#6881)
  Add `@section` to Compressor type (#6885)
  Parcel API improvements (#6866)
  Use stream-browserify for polyfilling instead (#6863)
  Add support for compressor plugins (#6776)
  Support for inline style attributes and inline scripts in SVG (#6797)
  Bump less (#6852)
  Make sure (non-React) SVGs are in separate bundles (#6757)
  Add support for injecting manifest into service workers (#6798)
  Fix 'does not export default' error with scope hoisting and url/worklet pipeline (#6803)
  Remaining cargo clippy fixes (#6829)
  Lazily install sharp only when needed (#6816)
  More cargo clippy suggestions (#6811)
  Don't emit runtime manifest for inline child bundles (#6807)
  Apply suggestions from rust-clippy (#6256)
  Fix add directoryExists function to matchFiles call. (#6784)
  Upgrade to Flow 158 (#6763)
  Revert "added cio headers (#6404)" (#6789)
  Process CSS in SVGs (#6743)
  ...
lettertwo added a commit that referenced this pull request Sep 10, 2021
@lettertwo
Merge branch 'v2' into bdo/number-edgetypes
fb3d269 
* v2: (38 commits)
  Use yarnpkg registry for all the things (#6908)
  Fix issue about loading configs from tsconfig.json (#6881)
  Add `@section` to Compressor type (#6885)
  Parcel API improvements (#6866)
  Use stream-browserify for polyfilling instead (#6863)
  Add support for compressor plugins (#6776)
  Support for inline style attributes and inline scripts in SVG (#6797)
  Bump less (#6852)
  Make sure (non-React) SVGs are in separate bundles (#6757)
  Add support for injecting manifest into service workers (#6798)
  Fix 'does not export default' error with scope hoisting and url/worklet pipeline (#6803)
  Remaining cargo clippy fixes (#6829)
  Lazily install sharp only when needed (#6816)
  More cargo clippy suggestions (#6811)
  Don't emit runtime manifest for inline child bundles (#6807)
  Apply suggestions from rust-clippy (#6256)
  Fix add directoryExists function to matchFiles call. (#6784)
  Upgrade to Flow 158 (#6763)
  Revert "added cio headers (#6404)" (#6789)
  Process CSS in SVGs (#6743)
  ...
lettertwo added a commit that referenced this pull request Sep 11, 2021
@lettertwo
Merge branch 'bdo/number-edgetypes' into lettertwo/buffer-backed-graph
f72e689 
* bdo/number-edgetypes: (70 commits)
  Use yarnpkg registry for all the things (#6908)
  Fix issue about loading configs from tsconfig.json (#6881)
  Add `@section` to Compressor type (#6885)
  Parcel API improvements (#6866)
  Use stream-browserify for polyfilling instead (#6863)
  Add support for compressor plugins (#6776)
  Support for inline style attributes and inline scripts in SVG (#6797)
  Bump less (#6852)
  Make sure (non-React) SVGs are in separate bundles (#6757)
  Add support for injecting manifest into service workers (#6798)
  Fix 'does not export default' error with scope hoisting and url/worklet pipeline (#6803)
  Remaining cargo clippy fixes (#6829)
  Lazily install sharp only when needed (#6816)
  More cargo clippy suggestions (#6811)
  Don't emit runtime manifest for inline child bundles (#6807)
  Apply suggestions from rust-clippy (#6256)
  Fix add directoryExists function to matchFiles call. (#6784)
  Upgrade to Flow 158 (#6763)
  Revert "added cio headers (#6404)" (#6789)
  Process CSS in SVGs (#6743)
  ...
lettertwo added a commit that referenced this pull request Sep 13, 2021
@lettertwo
Merge branch 'v2' into bdo/number-edgetypes
a97bcc1 
* v2: (38 commits)
  Use yarnpkg registry for all the things (#6908)
  Fix issue about loading configs from tsconfig.json (#6881)
  Add `@section` to Compressor type (#6885)
  Parcel API improvements (#6866)
  Use stream-browserify for polyfilling instead (#6863)
  Add support for compressor plugins (#6776)
  Support for inline style attributes and inline scripts in SVG (#6797)
  Bump less (#6852)
  Make sure (non-React) SVGs are in separate bundles (#6757)
  Add support for injecting manifest into service workers (#6798)
  Fix 'does not export default' error with scope hoisting and url/worklet pipeline (#6803)
  Remaining cargo clippy fixes (#6829)
  Lazily install sharp only when needed (#6816)
  More cargo clippy suggestions (#6811)
  Don't emit runtime manifest for inline child bundles (#6807)
  Apply suggestions from rust-clippy (#6256)
  Fix add directoryExists function to matchFiles call. (#6784)
  Upgrade to Flow 158 (#6763)
  Revert "added cio headers (#6404)" (#6789)
  Process CSS in SVGs (#6743)
  ...
lettertwo added a commit that referenced this pull request Sep 13, 2021
@lettertwo
Merge branch 'bdo/number-edgetypes' into lettertwo/buffer-backed-graph
7e72653 
* bdo/number-edgetypes: (70 commits)
  Use yarnpkg registry for all the things (#6908)
  Fix issue about loading configs from tsconfig.json (#6881)
  Add `@section` to Compressor type (#6885)
  Parcel API improvements (#6866)
  Use stream-browserify for polyfilling instead (#6863)
  Add support for compressor plugins (#6776)
  Support for inline style attributes and inline scripts in SVG (#6797)
  Bump less (#6852)
  Make sure (non-React) SVGs are in separate bundles (#6757)
  Add support for injecting manifest into service workers (#6798)
  Fix 'does not export default' error with scope hoisting and url/worklet pipeline (#6803)
  Remaining cargo clippy fixes (#6829)
  Lazily install sharp only when needed (#6816)
  More cargo clippy suggestions (#6811)
  Don't emit runtime manifest for inline child bundles (#6807)
  Apply suggestions from rust-clippy (#6256)
  Fix add directoryExists function to matchFiles call. (#6784)
  Upgrade to Flow 158 (#6763)
  Revert "added cio headers (#6404)" (#6789)
  Process CSS in SVGs (#6743)
  ...
lettertwo added a commit that referenced this pull request Sep 13, 2021
@lettertwo
Merge branch 'v2' into bdo/number-edgetypes
c0b7651 
* v2: (42 commits)
  Remove dead link to docs in diagnostic (#6913)
  Fix engines.parcel in SVG packager (#6911)
  Use imported Readable flow type instead of global (#6910)
  Use non-deprecated SVGO options in HTMLNanoOptimizer (#6785)
  Use yarnpkg registry for all the things (#6908)
  Fix issue about loading configs from tsconfig.json (#6881)
  Add `@section` to Compressor type (#6885)
  Parcel API improvements (#6866)
  Use stream-browserify for polyfilling instead (#6863)
  Add support for compressor plugins (#6776)
  Support for inline style attributes and inline scripts in SVG (#6797)
  Bump less (#6852)
  Make sure (non-React) SVGs are in separate bundles (#6757)
  Add support for injecting manifest into service workers (#6798)
  Fix 'does not export default' error with scope hoisting and url/worklet pipeline (#6803)
  Remaining cargo clippy fixes (#6829)
  Lazily install sharp only when needed (#6816)
  More cargo clippy suggestions (#6811)
  Don't emit runtime manifest for inline child bundles (#6807)
  Apply suggestions from rust-clippy (#6256)
  ...
lettertwo added a commit that referenced this pull request Sep 13, 2021
@lettertwo
Merge branch 'v2' into bdo/number-edgetypes
0b0a475 
* v2: (42 commits)
  Remove dead link to docs in diagnostic (#6913)
  Fix engines.parcel in SVG packager (#6911)
  Use imported Readable flow type instead of global (#6910)
  Use non-deprecated SVGO options in HTMLNanoOptimizer (#6785)
  Use yarnpkg registry for all the things (#6908)
  Fix issue about loading configs from tsconfig.json (#6881)
  Add `@section` to Compressor type (#6885)
  Parcel API improvements (#6866)
  Use stream-browserify for polyfilling instead (#6863)
  Add support for compressor plugins (#6776)
  Support for inline style attributes and inline scripts in SVG (#6797)
  Bump less (#6852)
  Make sure (non-React) SVGs are in separate bundles (#6757)
  Add support for injecting manifest into service workers (#6798)
  Fix 'does not export default' error with scope hoisting and url/worklet pipeline (#6803)
  Remaining cargo clippy fixes (#6829)
  Lazily install sharp only when needed (#6816)
  More cargo clippy suggestions (#6811)
  Don't emit runtime manifest for inline child bundles (#6807)
  Apply suggestions from rust-clippy (#6256)
  ...
lettertwo added a commit that referenced this pull request Sep 13, 2021
@lettertwo
Merge branch 'bdo/number-edgetypes' into lettertwo/buffer-backed-graph
f964457 
* bdo/number-edgetypes: (74 commits)
  Remove dead link to docs in diagnostic (#6913)
  Fix engines.parcel in SVG packager (#6911)
  Use imported Readable flow type instead of global (#6910)
  Use non-deprecated SVGO options in HTMLNanoOptimizer (#6785)
  Use yarnpkg registry for all the things (#6908)
  Fix issue about loading configs from tsconfig.json (#6881)
  Add `@section` to Compressor type (#6885)
  Parcel API improvements (#6866)
  Use stream-browserify for polyfilling instead (#6863)
  Add support for compressor plugins (#6776)
  Support for inline style attributes and inline scripts in SVG (#6797)
  Bump less (#6852)
  Make sure (non-React) SVGs are in separate bundles (#6757)
  Add support for injecting manifest into service workers (#6798)
  Fix 'does not export default' error with scope hoisting and url/worklet pipeline (#6803)
  Remaining cargo clippy fixes (#6829)
  Lazily install sharp only when needed (#6816)
  More cargo clippy suggestions (#6811)
  Don't emit runtime manifest for inline child bundles (#6807)
  Apply suggestions from rust-clippy (#6256)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mischnic mischnic mischnic approved these changes

@thebriando thebriando thebriando approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lettertwo @parcel-benchmark @mischnic @thebriando